Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3] ffbuild: read library linker objects from a file
Date: Mon, 17 Mar 2025 17:15:51 +0530
Message-ID: <dda48692-122e-427e-9294-65486c67b9bd@gyani.pro> (raw)
In-Reply-To: <tencent_95979CA6E0405A7235D180CE359F3EAB5709@qq.com>



On 2025-03-17 05:02 pm, Zhao Zhili wrote:
>
>> On Mar 13, 2025, at 21:02, Gyan Doshi <ffmpeg@gyani.pro> wrote:
>>
>> The linker command can exceed the maximum argument limit on MinGW,
>> especially for libavcodec.
>>
>> The objects list is now stored in a file and passed to the linker.
>> ---
>> v3:
>>   for reasons unknown to me, static linking doesn't appear to
>>   work on linux with escaped variables, so removed those.
>>   Someone please test on linux both static and shared builds.
>>
>> .gitignore          | 1 +
>> ffbuild/common.mak  | 2 +-
>> ffbuild/library.mak | 8 ++++++--
>> 3 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 9cfc78b414..430abaf91b 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -1,5 +1,6 @@
>> *.a
>> *.o
>> +*.objs
>> *.o.*
>> *.d
>> *.def
>> diff --git a/ffbuild/common.mak b/ffbuild/common.mak
>> index 023adb8567..ca45a0f368 100644
>> --- a/ffbuild/common.mak
>> +++ b/ffbuild/common.mak
>> @@ -214,7 +214,7 @@ $(TOOLOBJS): | tools
>>
>> OUTDIRS := $(OUTDIRS) $(dir $(OBJS) $(HOBJS) $(HOSTOBJS) $(SLIBOBJS) $(SHLIBOBJS) $(STLIBOBJS) $(TESTOBJS))
>>
>> -CLEANSUFFIXES     = *.d *.gcda *.gcno *.h.c *.ho *.map *.o *.pc *.ptx *.ptx.gz *.ptx.c *.ver *.version *$(DEFAULT_X86ASMD).asm *~ *.ilk *.pdb
>> +CLEANSUFFIXES     = *.d *.gcda *.gcno *.h.c *.ho *.map *.o *.objs *.pc *.ptx *.ptx.gz *.ptx.c *.ver *.version *$(DEFAULT_X86ASMD).asm *~ *.ilk *.pdb
>> LIBSUFFIXES       = *.a *.lib *.so *.so.* *.dylib *.dll *.def *.dll.a
>>
>> define RULES
>> diff --git a/ffbuild/library.mak b/ffbuild/library.mak
>> index 793e9d41fa..72e3872157 100644
>> --- a/ffbuild/library.mak
>> +++ b/ffbuild/library.mak
>> @@ -35,8 +35,10 @@ OBJS += $(SHLIBOBJS)
>> endif
>> $(SUBDIR)$(LIBNAME): $(OBJS) $(STLIBOBJS)
>> 	$(RM) $@
>> -	$(AR) $(ARFLAGS) $(AR_O) $^
>> +	$(Q)echo $^ > $@.objs
>> +	$(AR) $(ARFLAGS) $(AR_O) @$@.objs
> @file doesn’t supported by ar on macOS or BSD.

Do we have any FATE clients on these platforms?

I guess we can use  some guard (which?) to define an alternate recipe.

Regards,
Gyan


>
>> 	$(RANLIB) $@
>> +	-$(RM) $@.objs
>>
>> install-headers: install-lib$(NAME)-headers install-lib$(NAME)-pkgconfig
>>
>> @@ -66,8 +68,10 @@ $(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR)
>>
>> $(SUBDIR)$(SLIBNAME_WITH_MAJOR): $(OBJS) $(SHLIBOBJS) $(SLIBOBJS) $(SUBDIR)lib$(NAME).ver
>> 	$(SLIB_CREATE_DEF_CMD)
>> -	$$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) $$(filter %.o,$$^) $(FFEXTRALIBS)
>> +	$(Q)echo $$(filter %.o,$$^) > $$@.objs
>> +	$$(LD) $(SHFLAGS) $(LDFLAGS) $(LDSOFLAGS) $$(LD_O) @$$@.objs $(FFEXTRALIBS)
>> 	$(SLIB_EXTRA_CMD)
>> +	-$(RM) $$@.objs
>>
>> ifdef SUBDIR
>> $(SUBDIR)$(SLIBNAME_WITH_MAJOR): $(DEP_LIBS)
>> -- 
>> 2.46.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-17 11:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 13:02 Gyan Doshi
2025-03-15  7:56 ` Gyan Doshi
2025-03-17 10:17   ` Gyan Doshi
2025-03-17 11:32 ` Zhao Zhili
2025-03-17 11:45   ` Gyan Doshi [this message]
2025-03-17 11:59     ` Zhao Zhili
2025-03-17 13:11       ` Gyan Doshi
2025-03-17 13:21         ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dda48692-122e-427e-9294-65486c67b9bd@gyani.pro \
    --to=ffmpeg@gyani.pro \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git