Re: [FFmpeg-devel] [PATCH] avcodec/exrdec: restore applying color transfer characteristics for float16 samples

[James Almer <jamrial@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1499 bytes --]

On 3/15/2025 8:42 PM, Michael Niedermayer wrote:
> Hi
> 
> On Sat, Mar 15, 2025 at 08:36:33PM -0300, James Almer wrote:
>> On 3/15/2025 8:35 PM, Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Thu, Mar 13, 2025 at 11:08:09PM -0300, James Almer wrote:
>>>> Regression since 0e917389fe73c932049635d947bba076f1709589.
>>>> This change also reverts commit 431805c096738da7661a0baee2b12fe9724dcc95.
>>>>
>>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>>> ---
>>>>    libavcodec/exr.c | 38 ++++++++++++++++++++++++++++++++++++--
>>>>    1 file changed, 36 insertions(+), 2 deletions(-)
>>>
>>> We dont do that for any other codec.
>>> For every other case we export all the color and gamma information
>>> but do not modify the sample values to some "normalized" representation
>>>
>>> Its also lossy to do it in the decoder like this
>>>
>>> thx
>> We're still doing it for the float path, so in that case you may want to
>> remove it from there too.
> 
> I think we should remove it, but I think I have no samples for that code path.
> So i would not be able to test ...
> 
> thx

Even with no samples it should be a straightforward change.
But even then, since this feature includes two AVOptions that would be 
broken after such removal (and in fact currently are for half float 
samples), we should IMO deprecate them and remove the feature once the 
options are gone. That includes applying this patch to restore the 
functionality with half float samples.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".