From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DACFB4AEAC for ; Wed, 22 May 2024 17:29:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1F2C68D3E3; Wed, 22 May 2024 20:29:17 +0300 (EEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69D3F68D109 for ; Wed, 22 May 2024 20:29:11 +0300 (EEST) Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-51f71e4970bso8411243e87.2 for ; Wed, 22 May 2024 10:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1716398950; x=1717003750; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=zdFZ/HNyGq4kyeX2oLR/nGbYAfDEEmvyE8tVuBlQwcM=; b=Og8j+KUz8ctx532FBOrQOhqw9zfioIDg/KrV6mo3a1smKFwD9fRUlSy8sF/guq2169 nAzHzeTNad+V69ECfbI6XmkMQM00YamjetmvDfCK3BE3D7oylKEZlcqVEXxsL14IjB8o 3gGghu++9jGFmwjQ4E4t56noR9jDCkrRlrNmvIaxuR0AdOXqREZJGlEyoeF3X97UI+d0 k32nclBU07icX28a2AnWFxex8cFf1raaG9zMwpxW9qf8fsdTEooJ4Wdog7G2MD/FC89N g7Eq0daS3h4Eh+a4K8T1837y+87XJVo08Wmp8YVR0aXQnq8syWRkoxD9HfFKbaLAmS8E O+RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716398950; x=1717003750; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zdFZ/HNyGq4kyeX2oLR/nGbYAfDEEmvyE8tVuBlQwcM=; b=JTs5FBeRHiCRWPPWEOZaaUH6uz1TG8w5nzdK2HqSgK5gSywT1Mu+afh86wpuVo8UIt dfnyzt7fvO2wA3/EpL0tebBT4urGC+wRiFVH/GqKHx6lqk80A8vmvbYDimClXvbbNefE rIj1nBky8tnxlVRuzz1pUs5cCqGsG+xiKHa0Eur3BtTPchUJgUUb3rrTZhxZP474fkjA SfPjjZZFOdI+YfkU9jkITuUkpzE9AJJAE1qz9cRcMKL28tMJDgb7kdcvyaa1ZBxW1f03 KYaFlLJur+WqzL2hF3dYNxRBlrn3IT/Iz5mSoUjsQz9/8noeGOqqk3XvfAe5NxqeoYwk /1+A== X-Gm-Message-State: AOJu0YwaZSTMcp3AipXIo2ayWv6ueFa/jePELMkJmHTZdG9F1xSEl245 Tio6XgHyvujXVkgCfSx0opZl50k3x/mjzGDWU/WwOvxxLqDOCnENEHfBn1SP5Lm9QGuDy28Q1cX faQ== X-Google-Smtp-Source: AGHT+IETQAGMfOyOtYtPoq/NBR4meL7kKryvxH/BFz1h5PyBm3eAnfv05pKKE9/Pi7321OdnwjWQzA== X-Received: by 2002:ac2:43a1:0:b0:521:742a:baf4 with SMTP id 2adb3069b0e04-526beca9746mr2306740e87.9.1716398950387; Wed, 22 May 2024 10:29:10 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52237c6080bsm4320543e87.240.2024.05.22.10.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 10:29:09 -0700 (PDT) Date: Wed, 22 May 2024 20:29:05 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/vvc_alf: Don't use declare_func_emms X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 22 May 2024, Andreas Rheinhardt wrote: > VVC does not have MMX code at all, so one can use the stricter > declare_func to also check that the MMX state has not been clobbered > with (which would be an ABI violation). > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/vvc_alf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c > index 6dd89bfafc..f35fd2cd3e 100644 > --- a/tests/checkasm/vvc_alf.c > +++ b/tests/checkasm/vvc_alf.c > @@ -83,7 +83,7 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) > ptrdiff_t dst_stride = DST_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > + declare_func(void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > int width, int height, const int16_t *filter, const int16_t *clip, const int vb_pos); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); > @@ -137,7 +137,7 @@ static void check_alf_classify(VVCDSPContext *c, const int bit_depth) > ptrdiff_t stride = SRC_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, int *class_idx, int *transpose_idx, > + declare_func(void, int *class_idx, int *transpose_idx, > const uint8_t *src, ptrdiff_t src_stride, int width, int height, int vb_pos, int *gradient_tmp); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); > -- > 2.40.1 LGTM // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".