From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 56FC642645 for ; Mon, 21 Mar 2022 20:44:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5738868B15A; Mon, 21 Mar 2022 22:44:51 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C559E6802A5 for ; Mon, 21 Mar 2022 22:44:44 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 22LKihG5011630-22LKihG6011630; Mon, 21 Mar 2022 22:44:43 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id B64CEA1439; Mon, 21 Mar 2022 22:44:43 +0200 (EET) Date: Mon, 21 Mar 2022 22:44:43 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <0d906656-af31-412d-96aa-6c0ab1857714@riscosopen.org> Message-ID: References: <20220317185819.466470-1-bavison@riscosopen.org> <20220317185819.466470-7-bavison@riscosopen.org> <0d906656-af31-412d-96aa-6c0ab1857714@riscosopen.org> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 6/6] avcodec/vc1: Introduce fast path for unescaping bitstream buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 21 Mar 2022, Ben Avison wrote: > On 18/03/2022 19:10, Andreas Rheinhardt wrote: >> Ben Avison: >>> +static int vc1_unescape_buffer_neon(const uint8_t *src, int size, uint8_t >>> *dst) >>> +{ >>> + /* Dealing with starting and stopping, and removing escape bytes, are >>> + * comparatively less time-sensitive, so are more clearly expressed >>> using >>> + * a C wrapper around the assembly inner loop. Note that we assume a >>> + * little-endian machine that supports unaligned loads. */ >> >> You should nevertheless use AV_RL32 for your unaligned LE loads > > Thanks - I wasn't aware of that. I'll add it in. > >> 1. You should add some benchmarks to the commit message. > > Do you mean for each commit, or this one in particular? Are there any > particular standard files you'd expect to see benchmarked, or will the ones I > used in the cover-letter do? With checkasm tests available, it'd be nice to have per-function benchmarks in each of the patches that adds/tweaks a new function - so you can see e.g. that the NEON version of a function is e.g. 8x faster than the corresponding C function. That usually verifies that this particular assembly function is beneficial (there have been cases where people have contributed code which turned out to be slower than what the C compiler produces). Then overall, it can probably be nice to have a high level benchmark in e.g. the cover letter, like "speeds up decoding from xx fps to yy fps on hardware zz". (I'll make a longer reply to the other mail.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".