From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vvc_parser: Constify parser
Date: Thu, 29 Jun 2023 15:19:22 -0300
Message-ID: <dbf3c296-b6f8-7ecf-ec01-9b33cddc1ec4@gmail.com> (raw)
In-Reply-To: <AS8P250MB0744F6282DC26DDABA476F068F25A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 6/29/2023 3:19 PM, Andreas Rheinhardt wrote:
> The discrepancy between the definition and the declaration
> in parsers.c is actually UB.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/vvc_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc_parser.c b/libavcodec/vvc_parser.c
> index 4f7657f7ab..f350fe70a9 100644
> --- a/libavcodec/vvc_parser.c
> +++ b/libavcodec/vvc_parser.c
> @@ -571,7 +571,7 @@ static void vvc_parser_close(AVCodecParserContext *s)
> av_freep(&ctx->pc.buffer);
> }
>
> -AVCodecParser ff_vvc_parser = {
> +const AVCodecParser ff_vvc_parser = {
> .codec_ids = { AV_CODEC_ID_VVC },
> .priv_data_size = sizeof(VVCParserContext),
> .parser_init = vvc_parser_init,
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-29 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 18:17 [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h266: Remove double ; Andreas Rheinhardt
2023-06-29 18:18 ` James Almer
2023-06-29 18:20 ` Andreas Rheinhardt
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 2/4] avcodec/vvc_parser: Constify parser Andreas Rheinhardt
2023-06-29 18:19 ` James Almer [this message]
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter Andreas Rheinhardt
2023-06-29 18:19 ` James Almer
2023-06-29 19:18 ` Paul B Mahol
2023-06-29 19:36 ` Andreas Rheinhardt
2023-06-29 19:42 ` Paul B Mahol
2023-06-29 19:51 ` James Almer
2023-06-29 19:57 ` Andreas Rheinhardt
2023-07-01 12:01 ` Rémi Denis-Courmont
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 4/4] avformat/ac4dec: Constify demuxer Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf3c296-b6f8-7ecf-ec01-9b33cddc1ec4@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git