Re: [FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder using libaribcaption

[TADANO Tokumei <aimingoff@pc.nifty.jp>]

3rd ping!

Are there any other objections to this patch set?
If not, would someone push it to the repository?

A comment inline:

On 2022/06/17 0:30, TADANO Tokumei wrote:
> 
> On 2022/06/16 22:40, Soft Works wrote:
>>
>>
>>> -----Original Message-----
>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>>> TADANO Tokumei
>>> Sent: Thursday, June 16, 2022 3:23 PM
>>> To: ffmpeg-devel@ffmpeg.org
>>> Subject: Re: [FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder
>>> using libaribcaption
>>>
>>> ping again!
>>>
>>> Are there any objections to this patch set?
>>> If not, would someone push it to the repository?
>>>
>>> On 2022/06/08 18:48, TADANO Tokumei wrote:
>>>> ping
>>>>
>>>> The patch set has been well tested by Japanese ISDB-related
>>> developers and works fine.
>>>> I think it already has good quality to merge.
>>>>
>>>> It requires external library like libaribb24, but the feature is
>>> disabled by default.
>>>> There is no impact to current code without `--enable-
>>> libaribcaption` option is
>>>> specified at configuration. The patch set provide better subtitle
>>> feature
>>>> for ISDB users than libaribb24 if enabled.
>>
>> What exactly is better than with the other ARIB decoder?
>>
>>
>>>> On 2022/05/30 23:55, TADANO Tokumei wrote:
>>>>> This patch set add another ARIB caption decoder using
>>> libaribcaption
>>>>> external library: https://github.com/xqq/libaribcaption
>>>>> The library decodes subtitles of ISDB-based TV broadcasting.
>>>>> It is not only for Japanese ARIB STD-B24 caption, but also for
>>>>> Brazilian ABNT NBR 15606-1 and Philippines version of ISDB-T.
>>>>>
>>>>> Unlike libaribb24, it supports 3 types of subtitle outputs:
>>>>> * text: plain text
>>>>> * ass: ASS formatted text
>>>>> * bitmap: bitmap image
>>
>> This will become obsolete with the introduction of subtitle
>> filtering (https://github.com/ffstaging/FFmpeg/pull/18).

The subtitle filtering is not ready yet.
There is no reason to prevent to apply this patch set.
After the subtitle filtering will be ready, I can modify it to follow new API.

>> Just recently, Traian has joined and contributed a filter
>> for converting text  subtitles to graphic subtitles
>> (https://github.com/softworkz/FFmpeg/pull/1), which fills
>> the last remaining gap for subtitle conversions.
>>
>>
>> Is this the only advantage over the existing ARIB caption decoder?
> 
> The existing ARIB caption decoder (libaribb24) has lower reproducibility.
> For example, it lacks position information that is in original ARIB caption data.
> With this patch set, the intended caption is almost reproduced as ARIB standard
> states.
> 
> Thanks,
> TADANO
> 
>> Thanks,
>> sw
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".