From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C09EE4C994 for ; Mon, 10 Feb 2025 12:10:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0853B68BD4A; Mon, 10 Feb 2025 14:10:00 +0200 (EET) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F10268A919 for ; Mon, 10 Feb 2025 14:09:53 +0200 (EET) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5450622b325so1681095e87.1 for ; Mon, 10 Feb 2025 04:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1739189392; x=1739794192; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=ce9DSG79r0Nd3Zk/51Ic8IFSgs+UQKsoSJi4Fx0Jtqs=; b=j1pCzKfH0LGk9lNFvXDUYKp25Y2nIejX9zDHERxGIw+P6ObVj2gJyPHx7wXKIrapU1 e8jZVYah0UXIGsP25TceU1iATIZecDS1YiVNpIa/YFEwycFsRHgjy8cZhpM8/j3QNBZd 8FePwu5enQTRByUj4DFK9rZC70xYLYhepoZbMyTYSbfwcceaVkNTT0hPLzALXJTTf/gz fjTIHuRZIcCFqfx15sYMUTKoosMA9sPSkMhnCTfniGrBJwoT5Ng0OOoQvVU9937T9pT2 +ELlbwFx+U6ZBxyUfvu4dOpDgo62muDkq62qa6+8z0K9F9k+Cyyu6KK4fiQYKc3ijZtB 0C7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739189392; x=1739794192; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ce9DSG79r0Nd3Zk/51Ic8IFSgs+UQKsoSJi4Fx0Jtqs=; b=vGUBR+SqReayXFegTlrnZyozgRMVczKpmgzLof8+31em5w9pHEI2XjVyJ7zT00HSOs 18LPYn7s4tdETAqa7ABLtV7zDt6YrtGhYvRc3I/6LhcNo7zd9VYLp9kpWKqPDBjt2Sjx b4kBlt32TgKHfGbjsIXPRPTiSzLoJn6zzgWKUZVe7XoCbtiTdpXudMyt6N0bfyJ1YXm6 YYPlSUBLiR2hD1ciXG+MJFyMiJ3EL9dard5x05671XFp8q2Nj/3XLpkCBSpqCB7PhEn5 V5eYRztpptJgm+SQJIImzoAd1CctbmImi6IIcjv+tkqywAjbZgXgsNz5bDWnc6q+DZ45 EAuw== X-Gm-Message-State: AOJu0YwSa4tJw2NEbIV39r0EbNpRJyYEiOLoSAFswBfyfGArif2GSe5K p660LS2N3xnnU6tVWUhxiCVe9VJemuKTjMf55xEls10czolBIetaZLqCRhOox1YGZdZPH/0bDHm SgA== X-Gm-Gg: ASbGncuzg4wiQRRM69X+nwgB59Iv5vSbDWo+b/EBvE6rSvNevjEfT0M4ZZd3pnGYDwZ cFbFXl8Fuxp+i2XtkJQ8PiqllELfd2eIzyIDodo+OZ1SJaTYWkDNfdZTVTYfLCq9MAcvtlvGHz2 I4VjeBdio37MRfgYgppjSbQvZMyRDWjHdmYi13WYTse2AQtKwY6DN1Zo3/MAVLVUbiylmjiKAX0 CvXYFWtSWmkCtCDz8meNQZrJayR75qXRG2AmCXZdgQ/HCz+/yeQWos4zGLv3ykcPPx7D7Q2VCue DeI8nMVV6snOarlwpX2VZzXBEVJ7ZMMYWk2avo1ENFpIn/D36loeg7+ZCUB4VmGMjjJzZT2wzVn XvK/fPnM7ENg= X-Google-Smtp-Source: AGHT+IEQjV4K/atU7NvcU1T1fK9RhVnU6hMpnV34NyDgdx2O3PIgWd/QyWmrrBV7/+nzKLcQqWFCbQ== X-Received: by 2002:a05:6512:3a89:b0:545:109b:a9c7 with SMTP id 2adb3069b0e04-54510aaef72mr100504e87.35.1739189391999; Mon, 10 Feb 2025 04:09:51 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-545095d651esm427091e87.169.2025.02.10.04.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 04:09:51 -0800 (PST) Date: Mon, 10 Feb 2025 14:09:47 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: Message-ID: References: <20250205211929.4108078-1-martin@martin.st> <20250205211929.4108078-2-martin@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] checkasm: aacencdsp: Actually test nonzero values in quant_bands X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 7 Feb 2025, Martin Storsj=F6 wrote: > On Wed, 5 Feb 2025, Martin Storsj=F6 wrote: > >> Previously, we read elements from ff_aac_pow34sf_tab; however >> that table is initialized to zero; one needs to call >> ff_aac_float_common_init() to make sure that the table is >> initialized. >> = >> However, given the range of the input values, a large number of >> entries in ff_aac_pow34sf_tab would give results outside of the >> range for signed 32 bit integers. As the largest aac_cb_maxval >> entry is 16, it seems more reasonable to produce values within >> an order of mangitude of that value. >> = >> (When hitting INT_MIN, implementations may end up with different >> results depending on whether the value is negated as a float or >> as an int. This corner case is irrelevant in practice as this >> is way outside of the expected value range here.) >> = >> Coincidentally, this fixes linking checkasm with Apple's older >> linker. (In Xcode 15, Apple switched to a new linker. The one in >> older toolchains seems to have a bug where it won't figure out to >> load object files from a static library, if the only symbol >> referenced in the object file is a "common" symbol, i.e. one for >> a zero-initialized variable. This issue can also be reproduced with >> newer Apple toolchains by passing -Wl,-ld_classic to the linker.) >> --- >> tests/checkasm/aacencdsp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> = >> diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c >> index 5308a2ac03..713284211c 100644 >> --- a/tests/checkasm/aacencdsp.c >> +++ b/tests/checkasm/aacencdsp.c >> @@ -67,7 +67,7 @@ static void test_abs_pow34(AACEncDSPContext *s) >> static void test_quant_bands(AACEncDSPContext *s) >> { >> int maxval =3D randomize_elem(aac_cb_maxval); >> - float q34 =3D randomize_elem(ff_aac_pow34sf_tab); >> + float q34 =3D (float)rnd() / (UINT_MAX / 1024); >> float rounding =3D (rnd() & 1) ? ROUND_TO_ZERO : ROUND_STANDARD; >> LOCAL_ALIGNED_16(float, in, [BUF_SIZE]); >> LOCAL_ALIGNED_16(float, scaled, [BUF_SIZE]); >> -- = >> 2.43.0 > > These changes were OK'd by Lynne on irc, I'll push them later if there's = no = > more feedback on it. (I've tested these changes with thousands of differe= nt = > checkasm seeds now.) Pushed now. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".