From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1C09941223 for ; Fri, 18 Mar 2022 01:00:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4150068B02F; Fri, 18 Mar 2022 03:00:29 +0200 (EET) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 176D768A048 for ; Fri, 18 Mar 2022 03:00:23 +0200 (EET) Received: by mail-ot1-f50.google.com with SMTP id d15-20020a05683018ef00b005b2304fdeecso4691287otf.1 for ; Thu, 17 Mar 2022 18:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=oq3ZAQaEcc/wD+D++RoSbN/Mulg5zVn9byDCF05+2Xw=; b=krH++kfXACBMeMu147N0PhcI/mQ5+FJQT5yD3hWio0vWDpJJ10rMABpfSRescB00r5 0c8FRc39iGlxeuzljhJr88jtycUKoCbNqP2fF8832jTbTFOJYtYN9EA7JMtlhDEwF3X/ FJ4JjFGbepQLFf+zdMwnICN3SRMDKTQpgrxj+2rJKLIxZUsGnvvZhmAHOZyRaRI+cFAf NJlwuwUo10K6/Q5TDbpAQf/4g+wDmXTUipGTwIBr4nQhOlpHg8oUm/+zx3Yi9viyzAuN qG23EHrOc7jJITkLt7bq0LPzCQLPvPppLeC7RVeAobYu35VWQeG75f+KXuLQHBNzp8Ws v2CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=oq3ZAQaEcc/wD+D++RoSbN/Mulg5zVn9byDCF05+2Xw=; b=gmtPGWYLM1Mdc+cQd5x3MbIAjuPK87421WJ9zaiNb5SEv8opnLheXiaahZjusaAnxC 8P7B78qkh3OJZbT/oScHs6g58UImzmNepY292Mh/yJTxQAG22SIk/99+d0oz0YCa3dp3 nF4mwR+2FlLzzYYqvJtatc5R8BB9/VCWaDw8HKyjdIwLyFA+cpoGbEy2sXejTFzrWl6T BERU2sK4M817hLsZ/l/f3JOtkVBwE+iQbSkT7+r/2dy35Sf4Nxz0vy/z7tWB1XeuzVDA Tl/QxI+Q5PF6uRuIsPACSJlhEEOlmSfqVIc23eJFSgk4yqX2UUDFU8BlNxOdT5ZkVSos oMuQ== X-Gm-Message-State: AOAM531DDGiv7BqWyc9PxMe0RUxsAyxwsrKO/3ZTkyBaSWgiN80FHjtA dW9N5Lupab/edYDm/jv2ikzs37cscYNLbw== X-Google-Smtp-Source: ABdhPJwCbtevG0RWLrEjAtrezOr243876x6LDOh0XMncJ3CoamBfQmH/8qO4bX6TSyweP7cBdpEJzQ== X-Received: by 2002:a05:6830:268c:b0:5c9:6536:57fd with SMTP id l12-20020a056830268c00b005c9653657fdmr2598200otu.160.1647565220470; Thu, 17 Mar 2022 18:00:20 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id g12-20020a056870340c00b000d17b798ba9sm2939800oah.34.2022.03.17.18.00.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 18:00:19 -0700 (PDT) Message-ID: Date: Thu, 17 Mar 2022 22:00:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20220317233019.12049-1-michael@niedermayer.cc> <20220317233019.12049-2-michael@niedermayer.cc> <74943f9e-b07a-7fe4-fa83-09a9cbda21a0@gmail.com> In-Reply-To: <74943f9e-b07a-7fe4-fa83-09a9cbda21a0@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: CgpPbiAzLzE3LzIwMjIgOTowNyBQTSwgSmFtZXMgQWxtZXIgd3JvdGU6Cj4gCj4gCj4gT24gMy8x Ny8yMDIyIDg6NTIgUE0sIEphbWVzIEFsbWVyIHdyb3RlOgo+PiBPbiAzLzE3LzIwMjIgODozMCBQ TSwgTWljaGFlbCBOaWVkZXJtYXllciB3cm90ZToKPj4+IEZpeGVzOiBPdXQgb2YgYXJyYXkgd3Jp dGUKPj4+IEZpeGVzOiAKPj4+IDQ1NjEzL2NsdXN0ZXJmdXp6LXRlc3RjYXNlLW1pbmltaXplZC1m Zm1wZWdfQVZfQ09ERUNfSURfV01BTE9TU0xFU1NfZnV6emVyLTQ1MzkwNzM2MDYzMjAxMjggCj4+ Pgo+Pj4KPj4+IEZvdW5kLWJ5OiBjb250aW51b3VzIGZ1enppbmcgcHJvY2VzcyAKPj4+IGh0dHBz Oi8vZ2l0aHViLmNvbS9nb29nbGUvb3NzLWZ1enovdHJlZS9tYXN0ZXIvcHJvamVjdHMvZmZtcGVn Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIE5pZWRlcm1heWVyIDxtaWNoYWVsQG5pZWRlcm1h eWVyLmNjPgo+Pj4gLS0tCj4+PiDCoCBsaWJhdmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMgfCAzICsr Kwo+Pj4gwqAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS9saWJhdmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMgYi9saWJhdmNvZGVjL3dtYWxvc3NsZXNz ZGVjLmMKPj4+IGluZGV4IGNkMDViMjI2ODkuLjE3Mjg5MjA3MjkgMTAwNjQ0Cj4+PiAtLS0gYS9s aWJhdmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMKPj4+ICsrKyBiL2xpYmF2Y29kZWMvd21hbG9zc2xl c3NkZWMuYwo+Pj4gQEAgLTI4MSw2ICsyODEsOSBAQCBzdGF0aWMgYXZfY29sZCBpbnQgZGVjb2Rl X2luaXQoQVZDb2RlY0NvbnRleHQgCj4+PiAqYXZjdHgpCj4+PiDCoMKgwqDCoMKgIGF2X2NoYW5u ZWxfbGF5b3V0X3VuaW5pdCgmYXZjdHgtPmNoX2xheW91dCk7Cj4+PiDCoMKgwqDCoMKgIGF2X2No YW5uZWxfbGF5b3V0X2Zyb21fbWFzaygmYXZjdHgtPmNoX2xheW91dCwgY2hhbm5lbF9tYXNrKTsK Pj4+ICvCoMKgwqAgaWYgKHMtPm51bV9jaGFubmVscyAhPSBhdmN0eC0+Y2hfbGF5b3V0Lm5iX2No YW5uZWxzKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBBVkVSUk9SX1BBVENIV0VMQ09NRTsg Ly9hcmUgdGhlcmUgbm9uIGZ1enplZCBmaWxlcyAKPj4+IHdpdGggdGhpcyBvciBpcyBpdCBhbiBl cnJvciA/Cj4+Cj4+IHMtPm51bV9jaGFubmVscyBhdCB0aGlzIHBvaW50IGlzIHNldCB0byB0aGUg Y2hhbm5lbHMgY291bnQgdGhlIHVzZXIgCj4+IHNldCBiZWZvcmUgY2FsbGluZyBhdmNvZGVjX29w ZW4yKCkgKE5vcm1hbGx5IGZyb20gbGF2ZiksIGJ1dCBpdCBjb3VsZCAKPj4gYmUgYW55dGhpbmcu Cj4+IElmIGNoYW5uZWxfbWFzayBpcyB0YWtlbiBmcm9tIGV4dHJhZGF0YSwgbWF5YmUgaXQgc2hv dWxkIGJlIHVzZWQgdG8gCj4+IHNldCBzLT5udW1fY2hhbm5lbHMgaW5zdGVhZCBvZiBhYm9ydGlu ZyBiZWNhdXNlIHRoZSB1c2VyIHNldCB2YWx1ZSBhbmQgCj4+IGV4dHJhZGF0YSBkaXNhZ3JlZWQu Cj4+Cj4+IEFsc28sIGNhbiB5b3UgcmVwcm9kdWNlIHRoaXMgY3Jhc2ggYmVmb3JlIDNjOTMzYWY0 OTM/IHMtPm51bV9jaGFubmVscyAKPj4gd2FzIGJlaW5nIHNldCB0byB0aGUgdXNlciBzZXQgY2hh bm5lbCBjb3VudCB0b28sIHNhbWUgYXMgbm93Lgo+IAo+IFJpZ2h0LCBiZWZvcmUgdGhhdCBjb21t aXQgcy0+bnVtX2NoYW5uZWxzIGFuZCBhdmN0eC0+Y2hhbm5lbHMgd2VyZSAKPiBhbHdheXMgdGhl IHNhbWUsIGJ1dCBhdmN0eC0+Y2hhbm5lbF9sYXlvdXQgd2FzIHdoYXRldmVyIGNhbWUgZnJvbSAK PiBleHRyYWRhdGEsIGFuZCBpdHMgcG9wY250IGNvdWxkIGJlICE9IGF2Y3R4LT5jaGFubmVscy4K PiBBZnRlciBpdCwgYXZjdHgtPmNoX2xheW91dC5uYl9jaGFubmVscyBpcyBhbHdheXMgdGhlIHNh bWUgYXMgCj4gcG9wY250KGF2Y3R4LT5jaF9sYXlvdXQudS5tYXNrKSwgd2hpY2ggY2FuIGJlIGRp ZmZlcmVudCB0aGFuIAo+IHMtPm51bV9jaGFubmVscy4KPiAKPiBJIHRoaW5rIG15IHN1Z2dlc3Rp b24gYWJvdmUgdG8gdXNlIHRoZSBleHRyYWRhdGEgY2hhbm5lbCBtYXNrIGFuZCAKPiBpZ25vcmlu ZyB0aGUgdXNlciBzZXQgY2hhbm5lbCBjb3VudCBpcyB0aGUgYmVzdCBhcHByb2FjaCBmb3IgdGhp cy4KCkxpa2UgdGhpcyBtYXliZSAoY2hhbm5lbF9tYXNrIGNvdWxkIGluIHRoZW9yeSBiZSB6ZXJv LCBzbyBpbiB0aGF0IGNhc2UgCnRoZSB1c2VyIHNldCB2YWx1ZSBzaG91bGQgYmUgdXNlZCkuCgo+ IGRpZmYgLS1naXQgYS9saWJhdmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMgYi9saWJhdmNvZGVjL3dt YWxvc3NsZXNzZGVjLmMKPiBpbmRleCBjZDA1YjIyNjg5Li45MTVhZGQxOTYyIDEwMDY0NAo+IC0t LSBhL2xpYmF2Y29kZWMvd21hbG9zc2xlc3NkZWMuYwo+ICsrKyBiL2xpYmF2Y29kZWMvd21hbG9z c2xlc3NkZWMuYwo+IEBAIC0xOTcsMTUgKzE5Nyw2IEBAIHN0YXRpYyBhdl9jb2xkIGludCBkZWNv ZGVfaW5pdChBVkNvZGVjQ29udGV4dCAqYXZjdHgpCj4gICAgICAgICAgcmV0dXJuIEFWRVJST1Jf UEFUQ0hXRUxDT01FOwo+ICAgICAgfQo+IAo+IC0gICAgcy0+bWF4X2ZyYW1lX3NpemUgPSBNQVhf RlJBTUVTSVpFICogYXZjdHgtPmNoX2xheW91dC5uYl9jaGFubmVsczsKPiAtICAgIHMtPmZyYW1l X2RhdGEgPSBhdl9tYWxsb2N6KHMtPm1heF9mcmFtZV9zaXplICsgQVZfSU5QVVRfQlVGRkVSX1BB RERJTkdfU0laRSk7Cj4gLSAgICBpZiAoIXMtPmZyYW1lX2RhdGEpCj4gLSAgICAgICAgcmV0dXJu IEFWRVJST1IoRU5PTUVNKTsKPiAtCj4gLSAgICBzLT5hdmN0eCA9IGF2Y3R4Owo+IC0gICAgZmZf bGxhdWRkc3BfaW5pdCgmcy0+ZHNwKTsKPiAtICAgIGluaXRfcHV0X2JpdHMoJnMtPnBiLCBzLT5m cmFtZV9kYXRhLCBzLT5tYXhfZnJhbWVfc2l6ZSk7Cj4gLQo+ICAgICAgaWYgKGF2Y3R4LT5leHRy YWRhdGFfc2l6ZSA+PSAxOCkgewo+ICAgICAgICAgIHMtPmRlY29kZV9mbGFncyAgICA9IEFWX1JM MTYoZWRhdGFfcHRyICsgMTQpOwo+ICAgICAgICAgIGNoYW5uZWxfbWFzayAgICAgICA9IEFWX1JM MzIoZWRhdGFfcHRyICsgIDIpOwo+IEBAIC0yMzAsNiArMjIxLDMzIEBAIHN0YXRpYyBhdl9jb2xk IGludCBkZWNvZGVfaW5pdChBVkNvZGVjQ29udGV4dCAqYXZjdHgpCj4gICAgICAgICAgcmV0dXJu IEFWRVJST1JfUEFUQ0hXRUxDT01FOwo+ICAgICAgfQo+IAo+ICsgICAgaWYgKGNoYW5uZWxfbWFz aykgewo+ICsgICAgICAgIGF2X2NoYW5uZWxfbGF5b3V0X3VuaW5pdCgmYXZjdHgtPmNoX2xheW91 dCk7Cj4gKyAgICAgICAgYXZfY2hhbm5lbF9sYXlvdXRfZnJvbV9tYXNrKCZhdmN0eC0+Y2hfbGF5 b3V0LCBjaGFubmVsX21hc2spOwo+ICsgICAgfSBlbHNlCj4gKyAgICAgICAgYXZjdHgtPmNoX2xh eW91dC5vcmRlciA9IEFWX0NIQU5ORUxfT1JERVJfVU5TUEVDOwo+ICsKPiArICAgIHMtPm51bV9j aGFubmVscyA9IGF2Y3R4LT5jaF9sYXlvdXQubmJfY2hhbm5lbHM7Cj4gKwo+ICsgICAgLyogZXh0 cmFjdCBsZmUgY2hhbm5lbCBwb3NpdGlvbiAqLwo+ICsgICAgcy0+bGZlX2NoYW5uZWwgPSAtMTsK PiArCj4gKyAgICBpZiAoY2hhbm5lbF9tYXNrICYgOCkgewo+ICsgICAgICAgIHVuc2lnbmVkIGlu dCBtYXNrOwo+ICsgICAgICAgIGZvciAobWFzayA9IDE7IG1hc2sgPCAxNjsgbWFzayA8PD0gMSkK PiArICAgICAgICAgICAgaWYgKGNoYW5uZWxfbWFzayAmIG1hc2spCj4gKyAgICAgICAgICAgICAg ICArK3MtPmxmZV9jaGFubmVsOwo+ICsgICAgfQo+ICsKPiArICAgIHMtPm1heF9mcmFtZV9zaXpl ID0gTUFYX0ZSQU1FU0laRSAqIGF2Y3R4LT5jaF9sYXlvdXQubmJfY2hhbm5lbHM7Cj4gKyAgICBz LT5mcmFtZV9kYXRhID0gYXZfbWFsbG9jeihzLT5tYXhfZnJhbWVfc2l6ZSArIEFWX0lOUFVUX0JV RkZFUl9QQURESU5HX1NJWkUpOwo+ICsgICAgaWYgKCFzLT5mcmFtZV9kYXRhKQo+ICsgICAgICAg IHJldHVybiBBVkVSUk9SKEVOT01FTSk7Cj4gKwo+ICsgICAgcy0+YXZjdHggPSBhdmN0eDsKPiAr ICAgIGZmX2xsYXVkZHNwX2luaXQoJnMtPmRzcCk7Cj4gKyAgICBpbml0X3B1dF9iaXRzKCZzLT5w Yiwgcy0+ZnJhbWVfZGF0YSwgcy0+bWF4X2ZyYW1lX3NpemUpOwo+ICsKPiAgICAgIC8qIGdlbmVy aWMgaW5pdCAqLwo+ICAgICAgcy0+bG9nMl9mcmFtZV9zaXplID0gYXZfbG9nMihhdmN0eC0+Ymxv Y2tfYWxpZ24pICsgNDsKPiAKPiBAQCAtMjYzLDI0ICsyODEsMTAgQEAgc3RhdGljIGF2X2NvbGQg aW50IGRlY29kZV9pbml0KEFWQ29kZWNDb250ZXh0ICphdmN0eCkKPiAgICAgICAgICByZXR1cm4g QVZFUlJPUl9JTlZBTElEREFUQTsKPiAgICAgIH0KPiAKPiAtICAgIHMtPm51bV9jaGFubmVscyA9 IGF2Y3R4LT5jaF9sYXlvdXQubmJfY2hhbm5lbHM7Cj4gLQo+IC0gICAgLyogZXh0cmFjdCBsZmUg Y2hhbm5lbCBwb3NpdGlvbiAqLwo+IC0gICAgcy0+bGZlX2NoYW5uZWwgPSAtMTsKPiAtCj4gLSAg ICBpZiAoY2hhbm5lbF9tYXNrICYgOCkgewo+IC0gICAgICAgIHVuc2lnbmVkIGludCBtYXNrOwo+ IC0gICAgICAgIGZvciAobWFzayA9IDE7IG1hc2sgPCAxNjsgbWFzayA8PD0gMSkKPiAtICAgICAg ICAgICAgaWYgKGNoYW5uZWxfbWFzayAmIG1hc2spCj4gLSAgICAgICAgICAgICAgICArK3MtPmxm ZV9jaGFubmVsOwo+IC0gICAgfQo+IC0KPiAgICAgIHMtPmZyYW1lID0gYXZfZnJhbWVfYWxsb2Mo KTsKPiAgICAgIGlmICghcy0+ZnJhbWUpCj4gICAgICAgICAgcmV0dXJuIEFWRVJST1IoRU5PTUVN KTsKPiAKPiAtICAgIGF2X2NoYW5uZWxfbGF5b3V0X3VuaW5pdCgmYXZjdHgtPmNoX2xheW91dCk7 Cj4gLSAgICBhdl9jaGFubmVsX2xheW91dF9mcm9tX21hc2soJmF2Y3R4LT5jaF9sYXlvdXQsIGNo YW5uZWxfbWFzayk7Cj4gICAgICByZXR1cm4gMDsKPiAgfQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0CmZmbXBl Zy1kZXZlbEBmZm1wZWcub3JnCmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Zm bXBlZy1kZXZlbAoKVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCmZm bXBlZy1kZXZlbC1yZXF1ZXN0QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1bnN1YnNjcmliZSIu Cg==