From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 41A2E4367F
	for <ffmpegdev@gitmailbox.com>; Thu, 21 Jul 2022 13:38:36 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A8C968B53C;
	Thu, 21 Jul 2022 16:38:33 +0300 (EEST)
Received: from out2.migadu.com (out2.migadu.com [188.165.223.204])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE58568B294
 for <ffmpeg-devel@ffmpeg.org>; Thu, 21 Jul 2022 16:38:26 +0300 (EEST)
Message-ID: <dab7f347-e545-831a-857f-d5ba6fd78d0c@zanevaniperen.com>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com;
 s=key1; t=1658410706;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=tX6RMeVTPV6Xlit9PDtmOSQ1L4qxyXhTFSIgXoE4Q8A=;
 b=b/tFq/xFLtmTiZkizE47qPerthlEQS/M3/qaY85WnC0sDnXo0OfmS1ftyHVQjPX5HWmShH
 jdWHKvC30vzSjmgtlCLUy1m2eQPSfkOd43YdbD3B/IU53Xcl9jCMhUYXBm6eOuMo3zrkO6
 m8ugD4176ArSYC4sLgvM4hIv2bPTsoUq5Gfqgp8oBxkqKwFZUc/JHTCtsFVVs/Onq6F/qi
 cYN5+OQ/k2dmIe+M9AHrS1cHIHkfliHoBJXXTMOV2hFYV7Gbxsq0VC/O1WJd+Ka+dP2PVd
 RSJ6wM2V2O4DCztR+VYqoiwq9uTwTyAsZDx/MCJkw4BTB5+MPzW9IupYMqRf8Q==
Date: Thu, 21 Jul 2022 23:38:20 +1000
MIME-Version: 1.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220720144937.93133-1-zane@zanevaniperen.com>
 <20220720144937.93133-4-zane@zanevaniperen.com>
 <DB6PR0101MB2214A921457815489045A1C28F8E9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and
 include these headers.
From: Zane van Iperen <zane@zanevaniperen.com>
In-Reply-To: <DB6PR0101MB2214A921457815489045A1C28F8E9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: zanevaniperen.com
Subject: Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/argo_cvg: expose
 loop/reverb/checksum via metadata
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/dab7f347-e545-831a-857f-d5ba6fd78d0c@zanevaniperen.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On 21/7/22 08:00, Andreas Rheinhardt wrote:

>> +    if (av_dict_set_int(&st->metadata, "loop", ctx->header.loop, 0) < 0)
>> +        return AVERROR(ENOMEM);
>> +
>> +    if (av_dict_set_int(&st->metadata, "reverb", ctx->header.reverb, 0) < 0)
>> +        return AVERROR(ENOMEM);
>> +
>> +    if (av_dict_set_int(&st->metadata, "checksum", ctx->checksum, 0) < 0)
>> +        return AVERROR(ENOMEM);
>>
> Don't second-guess error codes (unless you have a good reason to).
> 

Right, don't know why I did that...

I'll apply in a few days (with the fixed return codes).

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".