From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/argo_cvg: expose loop/reverb/checksum via metadata
Date: Thu, 21 Jul 2022 23:38:20 +1000
Message-ID: <dab7f347-e545-831a-857f-d5ba6fd78d0c@zanevaniperen.com> (raw)
In-Reply-To: <DB6PR0101MB2214A921457815489045A1C28F8E9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
On 21/7/22 08:00, Andreas Rheinhardt wrote:
>> + if (av_dict_set_int(&st->metadata, "loop", ctx->header.loop, 0) < 0)
>> + return AVERROR(ENOMEM);
>> +
>> + if (av_dict_set_int(&st->metadata, "reverb", ctx->header.reverb, 0) < 0)
>> + return AVERROR(ENOMEM);
>> +
>> + if (av_dict_set_int(&st->metadata, "checksum", ctx->checksum, 0) < 0)
>> + return AVERROR(ENOMEM);
>>
> Don't second-guess error codes (unless you have a good reason to).
>
Right, don't know why I did that...
I'll apply in a few days (with the fixed return codes).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-07-21 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 14:49 [FFmpeg-devel] [PATCH v2 1/4] avformat/argo_cvg: name unk{1, 2} fields correctly Zane van Iperen
2022-07-20 14:49 ` [FFmpeg-devel] [PATCH v2 2/4] avformat/argo_cvg: add -loop and -reverb options Zane van Iperen
2022-07-20 14:49 ` [FFmpeg-devel] [PATCH v2 3/4] avformat/argo_cvg: remove trace logging Zane van Iperen
2022-07-20 14:49 ` [FFmpeg-devel] [PATCH v2 4/4] avformat/argo_cvg: expose loop/reverb/checksum via metadata Zane van Iperen
2022-07-20 22:00 ` Andreas Rheinhardt
2022-07-21 13:38 ` Zane van Iperen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab7f347-e545-831a-857f-d5ba6fd78d0c@zanevaniperen.com \
--to=zane@zanevaniperen.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git