From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8AA8D47B1B for ; Fri, 1 Dec 2023 18:25:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 629F268CF5F; Fri, 1 Dec 2023 20:25:08 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AD1E68CA74 for ; Fri, 1 Dec 2023 20:25:02 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3B1IP1xo027169-3B1IP1xp027169; Fri, 1 Dec 2023 20:25:01 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 63E69A1425; Fri, 1 Dec 2023 20:25:01 +0200 (EET) Date: Fri, 1 Dec 2023 20:25:01 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <5969017d-81db-470d-91bd-37c5b02ae5c1@myais.com.cn> Message-ID: References: <5969017d-81db-470d-91bd-37c5b02ae5c1@myais.com.cn> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 2/6] lavc/aarch64: new optimization for 8-bit hevc_epel_bi_h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: jdek@itanimul.li Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 18 Nov 2023, Logan.Lyu wrote: > diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S > b/libavcodec/aarch64/hevcdsp_epel_neon.S > index 74165273d7..070c8c9990 100644 > --- a/libavcodec/aarch64/hevcdsp_epel_neon.S > +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S > @@ -423,6 +423,263 @@ function ff_hevc_put_hevc_pel_bi_pixels64_8_neon, > export=1 > ret > endfunc > + > +function ff_hevc_put_hevc_epel_bi_h4_8_neon, export=1 > + load_epel_filterb x6, x7 > + sub x2, x2, #1 > + mov x10, #(MAX_PB_SIZE * 2) > +1: ld1 {v4.8b}, [x2], x3 > + ext v5.8b, v4.8b, v4.8b, #1 > + ext v6.8b, v4.8b, v4.8b, #2 > + ext v7.8b, v4.8b, v4.8b, #3 > + calc_epelb v16, v4, v5, v6, v7 > + ld1 {v20.4h}, [x4], x10 > + sqadd v16.8h, v16.8h, v20.8h > + sqrshrun v4.8b, v16.8h, #7 > + st1 {v4.s}[0], [x0], x1 > + subs w5, w5, #1 // height > + b.ne 1b > + ret > +endfunc > + > +function ff_hevc_put_hevc_epel_bi_h6_8_neon, export=1 > + load_epel_filterb x6, x7 > + sub w1, w1, #4 > + sub x2, x2, #1 > + mov x10, #(MAX_PB_SIZE * 2) > +1: ld1 {v24.16b}, [x2], x3 > + ext v26.16b, v24.16b, v24.16b, #1 > + ext v27.16b, v24.16b, v24.16b, #2 > + ext v28.16b, v24.16b, v24.16b, #3 > + calc_epelb v16, v24, v26, v27, v28 > + ld1 {v20.8h}, [x4], x10 > + sqadd v16.8h, v16.8h, v20.8h > + sqrshrun v16.8b, v16.8h, #7 > + st1 {v16.s}[0], [x0], #4 > + st1 {v16.h}[2], [x0], x1 > + subs w5, w5, #1 // height > + b.ne 1b > + ret > +endfunc > + > +function ff_hevc_put_hevc_epel_bi_h8_8_neon, export=1 > + load_epel_filterb x6, x7 > + sub x2, x2, #1 > + mov x10, #(MAX_PB_SIZE * 2) > +1: ld1 {v24.16b}, [x2], x3 > + ext v26.16b, v24.16b, v24.16b, #1 > + ext v27.16b, v24.16b, v24.16b, #2 > + ext v28.16b, v24.16b, v24.16b, #3 > + calc_epelb v16, v24, v26 v27, v28 Here, you're missing a comma between v26 and v27 - this produces an error when building for macOS, but not for other platforms. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".