From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: jdek@itanimul.li
Subject: Re: [FFmpeg-devel] [PATCH 2/6] lavc/aarch64: new optimization for 8-bit hevc_epel_bi_h
Date: Fri, 1 Dec 2023 20:25:01 +0200 (EET)
Message-ID: <da9d514-1b44-552c-a634-9c738b1ada83@martin.st> (raw)
In-Reply-To: <5969017d-81db-470d-91bd-37c5b02ae5c1@myais.com.cn>
On Sat, 18 Nov 2023, Logan.Lyu wrote:
> diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S
> b/libavcodec/aarch64/hevcdsp_epel_neon.S
> index 74165273d7..070c8c9990 100644
> --- a/libavcodec/aarch64/hevcdsp_epel_neon.S
> +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S
> @@ -423,6 +423,263 @@ function ff_hevc_put_hevc_pel_bi_pixels64_8_neon,
> export=1
> ret
> endfunc
> +
> +function ff_hevc_put_hevc_epel_bi_h4_8_neon, export=1
> + load_epel_filterb x6, x7
> + sub x2, x2, #1
> + mov x10, #(MAX_PB_SIZE * 2)
> +1: ld1 {v4.8b}, [x2], x3
> + ext v5.8b, v4.8b, v4.8b, #1
> + ext v6.8b, v4.8b, v4.8b, #2
> + ext v7.8b, v4.8b, v4.8b, #3
> + calc_epelb v16, v4, v5, v6, v7
> + ld1 {v20.4h}, [x4], x10
> + sqadd v16.8h, v16.8h, v20.8h
> + sqrshrun v4.8b, v16.8h, #7
> + st1 {v4.s}[0], [x0], x1
> + subs w5, w5, #1 // height
> + b.ne 1b
> + ret
> +endfunc
> +
> +function ff_hevc_put_hevc_epel_bi_h6_8_neon, export=1
> + load_epel_filterb x6, x7
> + sub w1, w1, #4
> + sub x2, x2, #1
> + mov x10, #(MAX_PB_SIZE * 2)
> +1: ld1 {v24.16b}, [x2], x3
> + ext v26.16b, v24.16b, v24.16b, #1
> + ext v27.16b, v24.16b, v24.16b, #2
> + ext v28.16b, v24.16b, v24.16b, #3
> + calc_epelb v16, v24, v26, v27, v28
> + ld1 {v20.8h}, [x4], x10
> + sqadd v16.8h, v16.8h, v20.8h
> + sqrshrun v16.8b, v16.8h, #7
> + st1 {v16.s}[0], [x0], #4
> + st1 {v16.h}[2], [x0], x1
> + subs w5, w5, #1 // height
> + b.ne 1b
> + ret
> +endfunc
> +
> +function ff_hevc_put_hevc_epel_bi_h8_8_neon, export=1
> + load_epel_filterb x6, x7
> + sub x2, x2, #1
> + mov x10, #(MAX_PB_SIZE * 2)
> +1: ld1 {v24.16b}, [x2], x3
> + ext v26.16b, v24.16b, v24.16b, #1
> + ext v27.16b, v24.16b, v24.16b, #2
> + ext v28.16b, v24.16b, v24.16b, #3
> + calc_epelb v16, v24, v26 v27, v28
Here, you're missing a comma between v26 and v27 - this produces an error
when building for macOS, but not for other platforms.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-01 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 2:06 Logan.Lyu
2023-12-01 18:25 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9d514-1b44-552c-a634-9c738b1ada83@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=jdek@itanimul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git