From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71D4A411D3 for ; Tue, 15 Feb 2022 14:26:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BEFB68B02F; Tue, 15 Feb 2022 16:26:03 +0200 (EET) Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 725ED68005B for ; Tue, 15 Feb 2022 16:25:56 +0200 (EET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com; s=key1; t=1644935155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0eQWftyv5Vqe5WOZRn9x0P3OoSjhc9TR4HoIYiyi+A=; b=HtG37KQHKvmOKoOOA8PLDyScia3SXocZppEiaUV8CNh6xU9xaLkHPWcJ8KptfBt7k7vUMo kbUfX9v7+ETX2J5dFERskew++fxGTI/VnObiiVW0ywqcTQJE6Q1IX0Fy/2iL5l+vIitnSC rV/rn6EelzXNsdf1ddurjd9vvHaOLtNbYtgXf1Frt0xlctQpt+UUzJdMFPOIOVdCcjkSHV PaVx5KsNCOWA4Z+OZNBhamZGt2vtqVvSSbxKD8JTi5Il4FrRg22pRNImAFTTGvp0DNdZo9 XGMqV9dFjiIf/oVApHG+cISfFvlI8XPAuC7fBlNqwWIzBXHOKu2cIYzRTp7+Bg== Date: Wed, 16 Feb 2022 00:25:52 +1000 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220215130517.25172-1-michael@niedermayer.cc> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zane van Iperen In-Reply-To: <20220215130517.25172-1-michael@niedermayer.cc> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: zanevaniperen.com Subject: Re: [FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 15/2/22 23:05, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/argo_cvg.c | 15 +++++---------- > libavformat/version.h | 2 +- > 2 files changed, 6 insertions(+), 11 deletions(-) > > diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c > index c5da32536d..dfdf126c17 100644 > --- a/libavformat/argo_cvg.c > +++ b/libavformat/argo_cvg.c > @@ -335,19 +335,14 @@ static int argo_cvg_write_trailer(AVFormatContext *s) > ArgoCVGMuxContext *ctx = s->priv_data; > int64_t ret; > > + ctx->checksum += (ctx->size & 255) > + + ((ctx->size>> 8) & 255) > + + ((ctx->size>>16) & 255) > + + (ctx->size>>24); > + ...because of course it's that simple. How did I miss that? No matter, lgtm! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".