From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum
Date: Wed, 16 Feb 2022 00:25:52 +1000
Message-ID: <da988ac9-276e-4326-ef44-bc3aa5d22f1e@zanevaniperen.com> (raw)
In-Reply-To: <20220215130517.25172-1-michael@niedermayer.cc>
On 15/2/22 23:05, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavformat/argo_cvg.c | 15 +++++----------
> libavformat/version.h | 2 +-
> 2 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c
> index c5da32536d..dfdf126c17 100644
> --- a/libavformat/argo_cvg.c
> +++ b/libavformat/argo_cvg.c
> @@ -335,19 +335,14 @@ static int argo_cvg_write_trailer(AVFormatContext *s)
> ArgoCVGMuxContext *ctx = s->priv_data;
> int64_t ret;
>
> + ctx->checksum += (ctx->size & 255)
> + + ((ctx->size>> 8) & 255)
> + + ((ctx->size>>16) & 255)
> + + (ctx->size>>24);
> +
...because of course it's that simple. How did I miss that?
No matter, lgtm!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-15 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 13:05 Michael Niedermayer
2022-02-15 14:25 ` Zane van Iperen [this message]
2022-02-15 21:17 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da988ac9-276e-4326-ef44-bc3aa5d22f1e@zanevaniperen.com \
--to=zane@zanevaniperen.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git