From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C9E9D42E0C for ; Fri, 7 Apr 2023 16:16:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE47E68B585; Fri, 7 Apr 2023 19:16:44 +0300 (EEST) Received: from iq.passwd.hu (unknown [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E1DC368A279 for ; Fri, 7 Apr 2023 19:16:37 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 11404E8C63 for ; Fri, 7 Apr 2023 18:15:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ydd7j3rI0ktB for ; Fri, 7 Apr 2023 18:15:49 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id E0051E86BE for ; Fri, 7 Apr 2023 18:15:48 +0200 (CEST) Date: Fri, 7 Apr 2023 18:15:48 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20230407160042.466129-2-zane@zanevaniperen.com> Message-ID: References: <20230407160042.466129-1-zane@zanevaniperen.com> <20230407160042.466129-2-zane@zanevaniperen.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 8 Apr 2023, Zane van Iperen wrote: > --- > libavcodec/brenderpix.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Just add #defines for the formats, so you don't need to use comments. Regards, Marton > > diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c > index 32e7329105..7b5bb7ce52 100644 > --- a/libavcodec/brenderpix.c > +++ b/libavcodec/brenderpix.c > @@ -171,27 +171,27 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame, > return ret; > } > switch (hdr.format) { > - case 3: > + case 3: // BR_PMT_INDEX_8 > avctx->pix_fmt = AV_PIX_FMT_PAL8; > bytes_pp = 1; > break; > - case 4: > + case 4: // BR_PMT_RGB_555 > avctx->pix_fmt = AV_PIX_FMT_RGB555BE; > bytes_pp = 2; > break; > - case 5: > + case 5: // BR_PMT_RGB_565 > avctx->pix_fmt = AV_PIX_FMT_RGB565BE; > bytes_pp = 2; > break; > - case 6: > + case 6: // BR_PMT_RGB_888 > avctx->pix_fmt = AV_PIX_FMT_RGB24; > bytes_pp = 3; > break; > - case 7: > + case 7: // BR_PMT_RGBX_888 > avctx->pix_fmt = AV_PIX_FMT_0RGB; > bytes_pp = 4; > break; > - case 8: // ARGB > + case 8: // BR_PMT_RGBA_8888 > avctx->pix_fmt = AV_PIX_FMT_ARGB; > bytes_pp = 4; > break; > -- > 2.39.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".