Re: [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch

[Marton Balint <cus@passwd.hu>]

On Sat, 8 Apr 2023, Zane van Iperen wrote:

> ---
> libavcodec/brenderpix.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Just add #defines for the formats, so you don't need to use comments.

Regards,
Marton

>
> diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c
> index 32e7329105..7b5bb7ce52 100644
> --- a/libavcodec/brenderpix.c
> +++ b/libavcodec/brenderpix.c
> @@ -171,27 +171,27 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame,
>         return ret;
>     }
>     switch (hdr.format) {
> -    case 3:
> +    case 3: // BR_PMT_INDEX_8
>         avctx->pix_fmt = AV_PIX_FMT_PAL8;
>         bytes_pp = 1;
>         break;
> -    case 4:
> +    case 4: // BR_PMT_RGB_555
>         avctx->pix_fmt = AV_PIX_FMT_RGB555BE;
>         bytes_pp = 2;
>         break;
> -    case 5:
> +    case 5: // BR_PMT_RGB_565
>         avctx->pix_fmt = AV_PIX_FMT_RGB565BE;
>         bytes_pp = 2;
>         break;
> -    case 6:
> +    case 6: // BR_PMT_RGB_888
>         avctx->pix_fmt = AV_PIX_FMT_RGB24;
>         bytes_pp = 3;
>         break;
> -    case 7:
> +    case 7: // BR_PMT_RGBX_888
>         avctx->pix_fmt = AV_PIX_FMT_0RGB;
>         bytes_pp = 4;
>         break;
> -    case 8: // ARGB
> +    case 8: // BR_PMT_RGBA_8888
>         avctx->pix_fmt = AV_PIX_FMT_ARGB;
>         bytes_pp = 4;
>         break;
> -- 
> 2.39.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".