From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA27346306 for ; Fri, 14 Jul 2023 18:19:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8659668C602; Fri, 14 Jul 2023 21:19:03 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4759768C355 for ; Fri, 14 Jul 2023 21:18:57 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 36EIIt4G025134-36EIIt4H025134 for ; Fri, 14 Jul 2023 21:18:55 +0300 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id BF48CA1428 for ; Fri, 14 Jul 2023 21:18:55 +0300 (EEST) Date: Fri, 14 Jul 2023 21:18:54 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20230714163448.31727-2-remi@remlab.net> Message-ID: References: <20230714163448.31727-2-remi@remlab.net> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/2] aarch64: remove VFP feature check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 14 Jul 2023, R=E9mi Denis-Courmont wrote: > This is not actually used for anything. The configure check causes the > CPU feature flag to be set, but nothing consumes it at all. > > While AArch64 does have VFP, it is only used for the scalar C code. > Conversely, it is still possible to disable VFP, by changing the > C compiler flags as before (though that only makes sense for an > hypothetical non-standard Armv8 platform without VFP). > > Note that this retains the "vfp" option flag, for backward > compatibility and on the very remote but theoretically possible chance > that FFmpeg actually makes use of it in the future. > > AV_CPU_FLAG_VFP is retained as it is actually used by AArch32. > --- > configure | 4 +--- > libavutil/aarch64/cpu.c | 3 +-- > 2 files changed, 2 insertions(+), 5 deletions(-) LGTM for both patches. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".