From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aarch64: remove VFP feature check
Date: Fri, 14 Jul 2023 21:18:54 +0300 (EEST)
Message-ID: <da668b7-f89d-5cf-e474-e89b65255fc9@martin.st> (raw)
In-Reply-To: <20230714163448.31727-2-remi@remlab.net>
On Fri, 14 Jul 2023, Rémi Denis-Courmont wrote:
> This is not actually used for anything. The configure check causes the
> CPU feature flag to be set, but nothing consumes it at all.
>
> While AArch64 does have VFP, it is only used for the scalar C code.
> Conversely, it is still possible to disable VFP, by changing the
> C compiler flags as before (though that only makes sense for an
> hypothetical non-standard Armv8 platform without VFP).
>
> Note that this retains the "vfp" option flag, for backward
> compatibility and on the very remote but theoretically possible chance
> that FFmpeg actually makes use of it in the future.
>
> AV_CPU_FLAG_VFP is retained as it is actually used by AArch32.
> ---
> configure | 4 +---
> libavutil/aarch64/cpu.c | 3 +--
> 2 files changed, 2 insertions(+), 5 deletions(-)
LGTM for both patches.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-07-14 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 16:34 Rémi Denis-Courmont
2023-07-14 18:18 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da668b7-f89d-5cf-e474-e89b65255fc9@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git