From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 334C345479
	for <ffmpegdev@gitmailbox.com>; Sat,  1 Apr 2023 04:13:18 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3320668C134;
	Sat,  1 Apr 2023 07:13:17 +0300 (EEST)
Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C8ED6883C7
 for <ffmpeg-devel@ffmpeg.org>; Sat,  1 Apr 2023 07:13:12 +0300 (EEST)
Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PpP063Grhz9sV4
 for <ffmpeg-devel@ffmpeg.org>; Sat,  1 Apr 2023 06:13:10 +0200 (CEST)
Message-ID: <d9fe3204-139c-0577-78d6-f50ca10d980b@gyani.pro>
Date: Sat, 1 Apr 2023 09:42:59 +0530
MIME-Version: 1.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20230330175221.1954-1-ffmpeg@gyani.pro>
From: Gyan Doshi <ffmpeg@gyani.pro>
In-Reply-To: <20230330175221.1954-1-ffmpeg@gyani.pro>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/d9fe3204-139c-0577-78d6-f50ca10d980b@gyani.pro/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Plan to push in 24h.

On 2023-03-30 11:22 pm, Gyan Doshi wrote:
> Fixes CID 1524608.
> ---
>   libavformat/tcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> index a889633457..db41394a84 100644
> --- a/libavformat/tcp.c
> +++ b/libavformat/tcp.c
> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
>           if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
>               av_freep(&s->local_port);
>               s->local_port = av_strdup(buf);
> -            if (!s->local_addr)
> +            if (!s->local_port)
>                   return AVERROR(ENOMEM);
>           }
>           if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".