* [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check
@ 2023-03-30 17:52 Gyan Doshi
2023-04-01 4:12 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2023-03-30 17:52 UTC (permalink / raw)
To: ffmpeg-devel
Fixes CID 1524608.
---
libavformat/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index a889633457..db41394a84 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
av_freep(&s->local_port);
s->local_port = av_strdup(buf);
- if (!s->local_addr)
+ if (!s->local_port)
return AVERROR(ENOMEM);
}
if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check
2023-03-30 17:52 [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check Gyan Doshi
@ 2023-04-01 4:12 ` Gyan Doshi
2023-04-02 4:50 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2023-04-01 4:12 UTC (permalink / raw)
To: ffmpeg-devel
Plan to push in 24h.
On 2023-03-30 11:22 pm, Gyan Doshi wrote:
> Fixes CID 1524608.
> ---
> libavformat/tcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> index a889633457..db41394a84 100644
> --- a/libavformat/tcp.c
> +++ b/libavformat/tcp.c
> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
> if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
> av_freep(&s->local_port);
> s->local_port = av_strdup(buf);
> - if (!s->local_addr)
> + if (!s->local_port)
> return AVERROR(ENOMEM);
> }
> if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check
2023-04-01 4:12 ` Gyan Doshi
@ 2023-04-02 4:50 ` Gyan Doshi
0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2023-04-02 4:50 UTC (permalink / raw)
To: ffmpeg-devel
On 2023-04-01 09:42 am, Gyan Doshi wrote:
> Plan to push in 24h.
Pushed as dd7e30724b739af9642917b1d04ba56d12e5e13f
>
> On 2023-03-30 11:22 pm, Gyan Doshi wrote:
>> Fixes CID 1524608.
>> ---
>> libavformat/tcp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
>> index a889633457..db41394a84 100644
>> --- a/libavformat/tcp.c
>> +++ b/libavformat/tcp.c
>> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char
>> *uri, int flags)
>> if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
>> av_freep(&s->local_port);
>> s->local_port = av_strdup(buf);
>> - if (!s->local_addr)
>> + if (!s->local_port)
>> return AVERROR(ENOMEM);
>> }
>> if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-02 4:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 17:52 [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check Gyan Doshi
2023-04-01 4:12 ` Gyan Doshi
2023-04-02 4:50 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git