From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E9BE146C26 for ; Thu, 6 Jul 2023 01:04:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3561F68C5FC; Thu, 6 Jul 2023 04:04:01 +0300 (EEST) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CDB1868C5D3 for ; Thu, 6 Jul 2023 04:03:54 +0300 (EEST) Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-6b867acbf6dso816692a34.0 for ; Wed, 05 Jul 2023 18:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688605433; x=1691197433; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fvBNjuxjFJ/7f3RaW667wAh6XfY4vV7txBgdt2q8mJI=; b=kCE8Z554lfpUPBQudOc2P2lEyz6Ta5v8zI6GUiA8PMwKVkSWyk90xdXLnzc5Zd1np6 2o+Jz+263DtdPfCR1f3CCFOQ72hLp4IsYOiZd5U41ZUav/+ztOOkmzpy4Poj+DLN2Xuz SFCgrjLbXb1Dj74A/i6K+7IosA+iXiSEAM1mlhxgpy3ox7B4+YEtjRrQc39h62Q4wDEs prvmPZgBXiEt8QKN8e+kQaxGIvxLhwrUNnwiJu2pRmUJV04vlDVE1xtINuJLQFkNb9XY FKEi0lAK7y+YCmYvY76ZHOxK6FQKSBDrmYNuYLUTC8SN6csrVWJaYoPlqM495CY6pC+n mBmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688605433; x=1691197433; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvBNjuxjFJ/7f3RaW667wAh6XfY4vV7txBgdt2q8mJI=; b=D5vie+mITCEs5IXUIKFj4n8dO6cz6JvMG7gO2Ea7/3AZsvfglHA4kxEWE1B5vkV/Jk W6q6bqDk01JfLC2vatD8zaDZd2qISq9C41iwfhy8gPCAdrzn62VJX0JNghrTDm9MUvOn ORPdKPrtYjilYmyW03TkLEL0/YL/eNdHj1MC8gXHYL2ufHVcmfYP6GrVmYkZY3Iigprs Od+jnj3apLrz/wXPEBWQUGHApbxTqYbeXL4pr+UBoquWWltt9cnveCET+Bm+gDaeYO4+ YZdHsQ3slG0MiErjS+EoX1mK5E9m0k9hsu/1VBhOh3KLGaZ/z4ds+H/TAhKalst5JXW8 frfw== X-Gm-Message-State: ABy/qLakQyd3AsqRxeRSI9hyiapYJwNcVJU2sPUTttPJP8UlL+JvH5f3 gitugrw8cWPrCSmzXDRFMwludI/Nepo= X-Google-Smtp-Source: APBJJlEJU9JYzEIMIP7gbwhzcZ0ZKjplit1RpXrEKyoQMxDC6cKsOruSIVFAl5w+Xlh14sB1vLZkCg== X-Received: by 2002:a05:6830:a86:b0:6b8:7653:dd5a with SMTP id n6-20020a0568300a8600b006b87653dd5amr1624800otu.12.1688605432652; Wed, 05 Jul 2023 18:03:52 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id d18-20020a056830045200b006b8a3875374sm236348otc.32.2023.07.05.18.03.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 18:03:52 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 22:03:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230705183601.4998-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/5/2023 9:41 PM, Nuo Mi wrote: >> + if (current->alf_cc_cb_filter_signal_flag) >> + ue(alf_cc_cb_filters_signalled_minus1, 0, 3); >> + else >> + infer(alf_cc_cb_filters_signalled_minus1, 0); >> > Not right, it will overread one filter set even > alf_cc_cb_filter_signal_flag is false. It will infer all values in alf_cc_cb_mapped_coeff_abs[0][0..7] and alf_cc_cb_coeff_sign[0][0..7] to be 0, as they are not present. > >> + for (k = 0; k <= current->alf_cc_cb_filters_signalled_minus1; k++) { >> + for (j = 0; j < 7; j++) { >> + if (current->alf_cc_cb_filter_signal_flag) >> + ubs(3, alf_cc_cb_mapped_coeff_abs[k][j], 2, k, j); >> + else >> + infer(alf_cc_cb_mapped_coeff_abs[k][j], 0); >> + if (current->alf_cc_cb_mapped_coeff_abs[k][j]) >> + ubs(1, alf_cc_cb_coeff_sign[k][j], 2, k, j); >> + else >> + infer(alf_cc_cb_coeff_sign[k][j], 0); >> + } >> + } >> + >> + if (current->alf_cc_cr_filter_signal_flag) >> + ue(alf_cc_cr_filters_signalled_minus1, 0, 3); >> + else >> + infer(alf_cc_cr_filters_signalled_minus1, 0); >> > Not right, Same as the above. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".