From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 078DF457F1 for ; Sun, 21 Jan 2024 12:06:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24ADD68CEB9; Sun, 21 Jan 2024 14:06:32 +0200 (EET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F48C68B3C3 for ; Sun, 21 Jan 2024 14:06:26 +0200 (EET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6dbcc7647c9so572707b3a.0 for ; Sun, 21 Jan 2024 04:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705838783; x=1706443583; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=LOxwTni4v1DWpEXLatbokU5vlq43kO9cpY3/DCj+N58=; b=h0anGQAFiBxSFARXf7EjI9ehUYrDpgf3XMUPfDEM4J/rrovPXu2Zd2JEvCn8Cjpj2Z NMA3Yfnieo+NnczT77Kx8DZyWDG1/7812L795HgEYV2JZereg4T73Noqvb7o9AXTjbnl rO6oxy51ShCE0lL7GjTsv2f6ymA1m2FxJI0AscfDzKn9xy0EMq+mIj4e5LZBa7Gxg4QF 3OVbuExxnzJD6c/1UK+ayHx5RoXZ+z7FnO9gxijngzCWgLEWcNMFXjhW2orvlGstOuFS cdclXhh9YOk4ErbCP+LP5RECsiSGeDJeuupXMJnFdIsarNK6sqsA7pcwWgCl860sVU93 ArTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705838783; x=1706443583; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LOxwTni4v1DWpEXLatbokU5vlq43kO9cpY3/DCj+N58=; b=sgL3sZCM5VBmtEjIllZA2ot1LBPLTk3rH34UkERF4Jb7Qq1uKZD1oDAVZ6UrzLzK9f YOo3JWP+9aYNU5DP69g1Eni32ZTG/aAJgg1FRK6lRCVmIZ+TtOZy0XFB1a8L3xdL7wT9 4+ZK5v7upQAGrONOr+6azpwkvoPoMZUBg2Ov8a86A+/P8XTzWuNOKqW6zkgnHK0j76Vm AWCca418sxar1WaejqDp/b80kY/GJbCs4tIubblIVIQr8jh4DstDxKNH3l8UEFyAysXl 3Y5lPrzlqEz3IT6ermdbKUirHy6NPQP7FBtuWk+U7i0OOiUzmwqv2NhY71JRbEIepg19 6McQ== X-Gm-Message-State: AOJu0Yy8AHU3OK23nit2hgIlgI7aPqjztAaLSQa/oGnPH4pZn+jOHhE2 y/kbhJy0n75ov+5k0CyFMsRGzktxMalgRTnJSJhwZT3hk5nG6T4gNzzzHOJg X-Google-Smtp-Source: AGHT+IFNBt7wzaeaIYZjA2bnNdsFKzncD4/zPJgb3vY9Sn2utQXy3i1uURAfYX1Tr20fAViG2TiRwg== X-Received: by 2002:a05:6a20:781c:b0:19a:2ea0:3ef4 with SMTP id a28-20020a056a20781c00b0019a2ea03ef4mr770222pzg.104.1705838783352; Sun, 21 Jan 2024 04:06:23 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id r6-20020a170902be0600b001cfc4d8ede5sm5646728pls.301.2024.01.21.04.06.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 04:06:22 -0800 (PST) Message-ID: Date: Sun, 21 Jan 2024 09:06:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240120220407.64141-1-jamrial@gmail.com> <170581842075.8914.15090755160718905890@lain.khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <170581842075.8914.15090755160718905890@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/2 v2] avutil: add a Tile Grid API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/21/2024 3:27 AM, Anton Khirnov wrote: > Quoting James Almer (2024-01-20 23:04:06) >> This includes a struct and helpers. It will be used to support container level >> cropping and tiled image formats, but should be generic enough for general >> usage. >> >> Signed-off-by: James Almer >> --- >> Extended to include fields used for cropping. Should make the struct reusable >> even for non tiled images, e.g. setting both rows and tiles to 1, in which case >> tile width and height would become analogous to coded_{witdh,height}. > > But why? What does cropping have to do with tiling? What advantage is > there to handling them in one struct? The struct does not need to be used for non tiled image scenarios, but could if we decide we don't want to add another struct that would only contain a subset of the fields present here. As to why said fields here present here, HEIF may use a clap box to define cropping for the final image, not for the tiles. This needs to be propagated, and the previous version of this API, which only defined cropping from right and bottom edges if output dimensions were smaller than the grid (standard case for tiled heif with no clap box), was not enough. Hence this change. I can rename this struct to Image Grid or something else, which might make it feel less awkward if we decide to reuse it. We still need to propagate container cropping from clap boxes and from Matroska elements after all. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".