Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: remove unused variables
Date: Wed, 24 Jan 2024 00:33:16 +0100
Message-ID: <d9e8f276d9b058830b7e2403496cb2549edfa395.camel@haerdin.se> (raw)
In-Reply-To: <20240123221240.222370-1-leo.izen@gmail.com>

tis 2024-01-23 klockan 17:12 -0500 skrev Leo Izen:
> Produces a -Wunused-variables warning with -Wall.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  libavformat/mxfenc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 685c11b3a5..febc1ccf8c 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -1487,7 +1487,6 @@ static void
> mxf_write_jpeg2000_subdesc(AVFormatContext *s, AVStream *st)
>      AVIOContext *pb = s->pb;
>      int64_t pos;
>      int component_count = av_pix_fmt_count_planes(st->codecpar-
> >format);
> -    int comp = 0;
>  
>      /* JPEG2000 subdescriptor key */
>      avio_write(pb, mxf_jpeg2000_subdescriptor_key, 16);
> @@ -2640,11 +2639,9 @@ static int
> mxf_parse_jpeg2000_frame(AVFormatContext *s, AVStream *st, AVPacket *
>  {
>      MXFContext *mxf = s->priv_data;
>      MXFStreamContext *sc = st->priv_data;
> -    AVIOContext *pb = s->pb;
>      int component_count = av_pix_fmt_count_planes(st->codecpar-
> >format);
>      GetByteContext g;
>      uint32_t j2k_ncomponents;
> -    int comp;
>  
>      if (mxf->header_written)
>          return 1;

Nice catch. Compiles fine

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-01-23 23:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 22:12 Leo Izen
2024-01-23 23:33 ` Tomas Härdin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9e8f276d9b058830b7e2403496cb2549edfa395.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git