From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 98CBB4F0D7 for ; Sun, 15 Jun 2025 16:56:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7C71B68AEA7; Sun, 15 Jun 2025 19:55:35 +0300 (EEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DF274687CA4 for ; Sun, 15 Jun 2025 19:55:33 +0300 (EEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-23633a6ac50so51485405ad.2 for ; Sun, 15 Jun 2025 09:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750006532; x=1750611332; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=q9e3Aspyajc3nW+/u0HgBgB+AcpoIjlhvZFqg6X8b9I=; b=DhssCJUukuioJJ+qpjqb63ArBQzvhetdKJicqnWnlUOF2zCoLRGqhDhjzF0u6Owvqk Xv+rfF+cuUlAb2cL/yfofd2jCQ0pDA07B6/cXN/UIVlBGtUqYxSSb+Wl4oIP4DWFJ7/t 10wGk+J8JgEEQhy++QM6MaxlvNM4jGIaV6qDNqvOvFGRMrbmx8QjCdn80ohnZCeXuRfM fR5vFGsh6AN3frcwNrRX4IrEIksNxNVLD7P8exMywN7W8B9CR2Y2aUGqiXkuaK5OgSIP 3cWjCloczFXN89i2Ngyy39BqTQKyLzu66f3rviR6c/zfDW4OHAak+LEjTYQYh8wUR5Y7 iOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750006532; x=1750611332; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q9e3Aspyajc3nW+/u0HgBgB+AcpoIjlhvZFqg6X8b9I=; b=S50C4RHZfy5XIv/u/vnH9w4pv+su/Eu65PLBlj9UjtKMOsalBhdA1EAiL/KZkeExIe DgG552Cxh9IVfBadpOdEzpuRjEY6amrMTbz331rEd4Y58I9nsGur7AV2YKd7tqjvRJfT 2LrX9OOLvG0uIfpoewnr/sRIF7qB2kzzxnedW+40Eqmzd8RUO6VbHq5zwC6ZUi+euZr4 al/jVxJ73GKFnzuwbSPv9QFnjdwqYsmqZkV4L0rvGJqF8bTb7kvk2S+FulaGeyq5LLn+ x8zkqmgpEE5v80K44mnP3lgvN3IXl2KC969lllUQO/tcP0hNOQCTKBaMPOJFIGzGm496 YB4Q== X-Gm-Message-State: AOJu0YzgK/StiKvP7laS1rE5+r10OGLsqNYH8lodschPC9J6G4MInrIu b8n8fgo4HesBspuF9LTSoKkFG8d96lLxczL6CKLlkgI/BxVGP3sOM2VNM5iPWQ== X-Gm-Gg: ASbGncs/aBIuW7fbxoeBPqj/y69HYOgtan/OAvG1YpQ+BQ6r0oTrkorQYOtG7c/Xq9W Ql4oHmT2SSION40oAXkBDahP4+yMCChOxFOu9kM5JaYHZHvk4kT9uS8dfZkVeGB5T8O1Y2yThLZ 26YFRBp5KJGAuDZEgov+HeXZum/uwGHU38HsiiPgBalMyqwurziu6H1vF5IskajZlH2b+n69LNv 1jYzMl1Q05UXXeFDvFe3wfeRiFGwhpeHTuW2tyFFE4bU33J8RmypjalqSC18FkjzY4HOrD5EMkx e5w3HGDmH2V0CH22ophsDeCVNe0DetyaqMdKMOCRVvmQc8nwgOcOpJWfTVaR1849PQKMUQiBhyS XfYxk+4Dp988xZIg/ X-Google-Smtp-Source: AGHT+IFCsAlyIYOwZgbIpN+eRBwSvBmSm+QrEx/05hvca5wUzoQRcM4tXxo56Qd45iBZv2YSs8YzmQ== X-Received: by 2002:a17:902:e747:b0:234:d292:be7a with SMTP id d9443c01a7336-2366b337fe8mr101575575ad.1.1750006531853; Sun, 15 Jun 2025 09:55:31 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d88c222sm46009495ad.21.2025.06.15.09.55.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jun 2025 09:55:31 -0700 (PDT) From: Andreas Rheinhardt X-Google-Original-From: Andreas Rheinhardt Message-Id: In-Reply-To: References: Date: Sun, 15 Jun 2025 16:53:59 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 08/47] avcodec/mpeg12dec: Don't store block_last_index unnecessarily X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Andreas Rheinhardt Given that the MPEG-1/2 decoders unquantize the blocks on their own, block_last_index is only used to signal to ff_mpv_reconstruct_mb() whether a block is skipped or not; but this is only checked for inter macroblocks, so it is unnecessary to set block_last_index for intra macroblocks. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12.c | 4 ++-- libavcodec/mpeg12dec.c | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index 3056c53c7c..62a77b6806 100644 --- a/libavcodec/mpeg12.c +++ b/libavcodec/mpeg12.c @@ -276,7 +276,7 @@ end: } if (i > MAX_INDEX) - i = AVERROR_INVALIDDATA; + return AVERROR_INVALIDDATA; - return i; + return 0; } diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 9cf1bb9b28..5d2719d0f0 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -377,7 +377,6 @@ static inline int mpeg2_decode_block_intra(MpegEncContext *s, check_scantable_index(s, i); - s->block_last_index[n] = i; return 0; } @@ -518,8 +517,6 @@ static int mpeg_decode_mb(MpegEncContext *s, int16_t block[12][64]) s->mb_x, s->mb_y); return ret; } - - s->block_last_index[i] = ret; } } } else { -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".