From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 4B99B4AAD9
	for <ffmpegdev@gitmailbox.com>; Sun, 12 May 2024 20:22:20 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0469B68D6A0;
	Sun, 12 May 2024 23:22:18 +0300 (EEST)
Received: from vidala.lynne.ee (vidala.pars.ee [116.203.72.101])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 60F9B68D4FF
 for <ffmpeg-devel@ffmpeg.org>; Sun, 12 May 2024 23:22:11 +0300 (EEST)
Message-ID: <d8e07419-b256-4fa7-b8c6-bfc276392acc@lynne.ee>
Date: Sun, 12 May 2024 22:22:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20240512160657.2733-4-jamrial@gmail.com>
 <20240512185156.60144-1-jamrial@gmail.com>
Content-Language: en-US
In-Reply-To: <20240512185156.60144-1-jamrial@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 6/8 v2] x86/flacdsp: add a SSE2 version
 of wasted32
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Lynne <dev@lynne.ee>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/d8e07419-b256-4fa7-b8c6-bfc276392acc@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 12/05/2024 20:51, James Almer wrote:
> flac_wasted_32_c: 851.3
> flac_wasted_32_sse2: 41.3
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/x86/flacdsp.asm    | 24 ++++++++++++++++++++++++
>   libavcodec/x86/flacdsp_init.c |  3 +++
>   2 files changed, 27 insertions(+)
> 
> diff --git a/libavcodec/x86/flacdsp.asm b/libavcodec/x86/flacdsp.asm
> index f38eb7db76..21b2439bc0 100644
> --- a/libavcodec/x86/flacdsp.asm
> +++ b/libavcodec/x86/flacdsp.asm
> @@ -89,6 +89,30 @@ LPC_32 sse4, 32, psrlq
>   LPC_32 xop,  32, psrlq
>   %endif
>   
> +INIT_XMM sse2
> +cglobal flac_wasted_32, 3,3,5, decoded, wasted, len
> +    shl   lend, 2
> +    add   decodedq, lenq
> +    neg   lenq
> +    movd  m4, wastedd
> +ALIGN 16
> +.loop:
> +    mova  m0, [decodedq+lenq+mmsize*0]
> +    mova  m1, [decodedq+lenq+mmsize*1]
> +    mova  m2, [decodedq+lenq+mmsize*2]
> +    mova  m3, [decodedq+lenq+mmsize*3]
> +    pslld m0, m4
> +    pslld m1, m4
> +    pslld m2, m4
> +    pslld m3, m4
> +    mova  [decodedq+lenq+mmsize*0], m0
> +    mova  [decodedq+lenq+mmsize*1], m1
> +    mova  [decodedq+lenq+mmsize*2], m2
> +    mova  [decodedq+lenq+mmsize*3], m3
> +    add lenq, mmsize * 4
> +    jl .loop
> +    RET

Looks good
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".