* [FFmpeg-devel] [PATCH] Fixed nvenc release dump [not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.0878c2f3-5737-4b62-9d31-5d0da2c49cfe.d15758d7-70f8-4474-9c95-fb984463140a@emailsignatures365.codetwo.com> @ 2023-11-24 7:04 ` GOOR, Jean-Noel 2023-11-24 12:38 ` Timo Rothenpieler 0 siblings, 1 reply; 3+ messages in thread From: GOOR, Jean-Noel @ 2023-11-24 7:04 UTC (permalink / raw) To: ffmpeg-devel Signed-off-by: GOOR, Jean-Noël <jn.goor@evs.com> --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3c68ed3930..1f8c7e8c0e 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode_close(AVCodecContext *avctx) av_fifo_freep2(&ctx->unused_surface_queue); if (ctx->frame_data_array) { - for (i = 0; i < ctx->nb_surfaces; i++) + for (i = 0; i < ctx->frame_data_array_nb; i++) av_buffer_unref(&ctx->frame_data_array[i].frame_opaque_ref); av_freep(&ctx->frame_data_array); } -- 2.37.3.windows.1 Jean-Noël GOOR - Senior Software Architect T. +32 4 361.58.70 jn.goor@evs.com EVS Broadcast Equipment - Rue Bois Saint Jean, 13 - 4102 Seraing - BELGIUM EVS Broadcast Equipment is a commercial name which is used for all legal entities of our group. At EVS we give utmost importance to your data's privacy. If you wish to know more on how we manage your data and on your rights, please consult our Privacy Statement. This message may contain confidential information and is intended solely for the use of the addressee. Please do not use or publish the contained information without the agreement of the sender. If you are not the intended recipient of this message, please notify the sender and do not disclose, use, disseminate or copy this message. Please consider the environment before printing this email. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fixed nvenc release dump 2023-11-24 7:04 ` [FFmpeg-devel] [PATCH] Fixed nvenc release dump GOOR, Jean-Noel @ 2023-11-24 12:38 ` Timo Rothenpieler 0 siblings, 0 replies; 3+ messages in thread From: Timo Rothenpieler @ 2023-11-24 12:38 UTC (permalink / raw) To: ffmpeg-devel I don't quite understand the commit message. It should start with "avcodec/nvenc:" and then state what it's changing and why. On 24/11/2023 08:04, GOOR, Jean-Noel wrote: > Signed-off-by: GOOR, Jean-Noël <jn.goor@evs.com> > --- > libavcodec/nvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 3c68ed3930..1f8c7e8c0e 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode_close(AVCodecContext *avctx) > av_fifo_freep2(&ctx->unused_surface_queue); > > if (ctx->frame_data_array) { > - for (i = 0; i < ctx->nb_surfaces; i++) > + for (i = 0; i < ctx->frame_data_array_nb; i++) Wrong indentation. The change itself looks correct to me on first glance. Did you find this via a leak checker? > av_buffer_unref(&ctx->frame_data_array[i].frame_opaque_ref); > av_freep(&ctx->frame_data_array); > } _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <75bc2482-ee76-46e0-b158-59812d9b556b.6b3277fd-9509-4eec-8a03-dcd135675389.710aff08-3149-4359-b808-f5cd67e63c91@emailsignatures365.codetwo.com>]
[parent not found: <75bc2482-ee76-46e0-b158-59812d9b556b.f81fd677-2c20-4d59-96be-51794e3dd064.4d4d527c-2a22-427f-ada8-1e8f5e860956@emailsignatures365.codetwo.com>]
[parent not found: <75bc2482-ee76-46e0-b158-59812d9b556b.0878c2f3-5737-4b62-9d31-5d0da2c49cfe.e2ffd514-4b29-4fb8-9897-62d808ad9d0e@emailsignatures365.codetwo.com>]
* [FFmpeg-devel] [PATCH] Fixed nvenc release dump [not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.0878c2f3-5737-4b62-9d31-5d0da2c49cfe.e2ffd514-4b29-4fb8-9897-62d808ad9d0e@emailsignatures365.codetwo.com> @ 2023-11-23 8:29 ` GOOR, Jean-Noel 0 siblings, 0 replies; 3+ messages in thread From: GOOR, Jean-Noel @ 2023-11-23 8:29 UTC (permalink / raw) To: ffmpeg-devel Signed-off-by: GOOR, Jean-Noël <jn.goor@evs.com> --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3c68ed3930..1f8c7e8c0e 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode_close(AVCodecContext *avctx) av_fifo_freep2(&ctx->unused_surface_queue); if (ctx->frame_data_array) { - for (i = 0; i < ctx->nb_surfaces; i++) + for (i = 0; i < ctx->frame_data_array_nb; i++) av_buffer_unref(&ctx->frame_data_array[i].frame_opaque_ref); av_freep(&ctx->frame_data_array); } -- 2.37.3.windows.1 Jean-Noël GOOR - Senior Software Architect T. +32 4 361.58.70 jn.goor@evs.com EVS Broadcast Equipment - Rue Bois Saint Jean, 13 - 4102 Seraing - BELGIUM EVS Broadcast Equipment is a commercial name which is used for all legal entities of our group. At EVS we give utmost importance to your data's privacy. If you wish to know more on how we manage your data and on your rights, please consult our Privacy Statement. This message may contain confidential information and is intended solely for the use of the addressee. Please do not use or publish the contained information without the agreement of the sender. If you are not the intended recipient of this message, please notify the sender and do not disclose, use, disseminate or copy this message. Please consider the environment before printing this email. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-24 12:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <75bc2482-ee76-46e0-b158-59812d9b556b.6b3277fd-9509-4eec-8a03-dcd135675389.0e59a80c-5bf2-4680-b41a-4eb1b2bdcf08@emailsignatures365.codetwo.com>
[not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.f81fd677-2c20-4d59-96be-51794e3dd064.4698ae07-9841-4b8f-9f5a-42c776da289f@emailsignatures365.codetwo.com>
[not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.0878c2f3-5737-4b62-9d31-5d0da2c49cfe.d15758d7-70f8-4474-9c95-fb984463140a@emailsignatures365.codetwo.com>
2023-11-24 7:04 ` [FFmpeg-devel] [PATCH] Fixed nvenc release dump GOOR, Jean-Noel
2023-11-24 12:38 ` Timo Rothenpieler
[not found] <75bc2482-ee76-46e0-b158-59812d9b556b.6b3277fd-9509-4eec-8a03-dcd135675389.710aff08-3149-4359-b808-f5cd67e63c91@emailsignatures365.codetwo.com>
[not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.f81fd677-2c20-4d59-96be-51794e3dd064.4d4d527c-2a22-427f-ada8-1e8f5e860956@emailsignatures365.codetwo.com>
[not found] ` <75bc2482-ee76-46e0-b158-59812d9b556b.0878c2f3-5737-4b62-9d31-5d0da2c49cfe.e2ffd514-4b29-4fb8-9897-62d808ad9d0e@emailsignatures365.codetwo.com>
2023-11-23 8:29 ` GOOR, Jean-Noel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git