Re: [FFmpeg-devel] [PATCH] Fixed nvenc release dump

From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] Fixed nvenc release dump
Date: Fri, 24 Nov 2023 13:38:16 +0100
Message-ID: <d8c5103a-509b-414a-a88b-feecb6e06170@rothenpieler.org> (raw)
In-Reply-To: <PAXPR10MB510308EA2779D5FEADEA420DEAB8A@PAXPR10MB5103.EURPRD10.PROD.OUTLOOK.COM>

I don't quite understand the commit message.
It should start with "avcodec/nvenc:" and then state what it's changing 
and why.

On 24/11/2023 08:04, GOOR, Jean-Noel wrote:
> Signed-off-by: GOOR, Jean-Noël <jn.goor@evs.com>
> ---
>   libavcodec/nvenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> index 3c68ed3930..1f8c7e8c0e 100644
> --- a/libavcodec/nvenc.c
> +++ b/libavcodec/nvenc.c
> @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode_close(AVCodecContext *avctx)
>       av_fifo_freep2(&ctx->unused_surface_queue);
>   
>       if (ctx->frame_data_array) {
> -        for (i = 0; i < ctx->nb_surfaces; i++)
> +       for (i = 0; i < ctx->frame_data_array_nb; i++)

Wrong indentation.

The change itself looks correct to me on first glance.
Did you find this via a leak checker?

>               av_buffer_unref(&ctx->frame_data_array[i].frame_opaque_ref);
>           av_freep(&ctx->frame_data_array);
>       }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".