Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Dennis Sädtler via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: "Martin Storsjö" <martin@martin.st>,
	"Dennis Sädtler via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
Cc: "Dennis Sädtler" <dennis@obsproject.com>
Subject: Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end
Date: Sun, 2 Jun 2024 22:45:40 +0200
Message-ID: <d8a8cb94-ac6a-f914-36f3-05c9511593d9@obsproject.com> (raw)
In-Reply-To: <927a8e83-a337-e41-1933-c67261ef15f@martin.st>

On 2024-06-02 21:36, Martin Storsjö wrote:
> On Sat, 1 Jun 2024, Dennis Sädtler via ffmpeg-devel wrote:
>
>> Should the ftyp atom also be updated to remove brands no longer 
>> required for non-fragmented files?
>> I'm not sure how important that is in real-world scenarios, so it 
>> might not be worth it to deal with some of the additional changes 
>> required e.g. to deal with the new ftyp possibly being a different size.
>
> Hmm, good point, I hadn't thought about that. I'd prefer not to do 
> that, as it becomes a bit more of a mess to change the size of the ftyp.

Indeed, though as far as I can tell only the offset and size of the mdat 
would need to be changed, since everything past the ftyp is "disposable" 
anyway.
But as I initially mentioned, I have no idea if there are real-word 
cases of players refusing a file purely based on those brands.

>> Since coincidentally I've implemented the exact same feature in a 
>> different application a couple weeks ago I'll also throw in the fun 
>> fact that files produced this way can be smaller than regular MP4s 
>> for long and/or large files.
>> This is due to the lack of interleaving of A/V samples resulting in 
>> the file having much fewer but larger chunks, which means the moov 
>> atom - mainly the stco/co64 and stsc boxes - can be much smaller.
>
> Oh, indeed, that's a good point. But on the other hand, the file ends 
> up containing all the leftover moof boxes in the mdat. But are you 
> saying that a compact moov + leftover moof, still is smaller than one 
> large moov, in your practical test cases?

Yep, that's what I meant! The initial ("empty") moov and following moof 
boxes aren't all that big, so once you go over a certain threshold 
(which I haven't calculated) this method ends up having a negative overhead.

I have a regular MP4 of a Twitch live stream (1 video + 1 audio track) 
where the moov alone ends up being ~40 MiB, so they can get quite large. 
That may be part of why the newer ISO-BMFF revisions actually have a 
feature for compressing moov/moof/sidx boxes (that nobody has 
implemented as far as I can tell).

> Btw, the patch in this form has one minimal time gap for when the file 
> can end up unrecoverable; we patch the mdat size (hiding the moof 
> boxes) before we write the moov - if we die at that specific moment, 
> we'd have an unreadable file. I guess it should be possible to reorder 
> these two calls as well - but it makes for a slightly bigger patch.

First writing the moov and then hiding the fragmentation is what I ended 
up doing in my implementation. Might be overkill, but would certainly 
make it the "safest" it can be.

In my implementation I also ended up changing the placeholder "free" 
atom at the start to be 16 bytes so that I could write the mdat header 
non-destructively and allow the fragmented structure to be preserved 
entirely. This was mostly done for easier manual recovery in case 
something goes wrong with the full moov, though again, probably overkill.

Finally, I've also had a somewhat cursed thought about having a second 
always-hidden ftyp before the initial moov, which would then allow you 
to use the same file for progressive download and DASH/HLS streaming by 
using range-requests (e.g. via BYTERANGE) to skip the first ftyp + mdat 
header for the init segment and then using the fragments as normal. 
Though that goes beyond the scope of this patch, I just had to get it 
out there in case anybody thinks that might actually be fun to try :P

~Dennis

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-06-02 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  8:53 Martin Storsjö
2024-05-31 12:18 ` Timo Rothenpieler
2024-05-31 12:38   ` Martin Storsjö
2024-06-01 12:38 ` Dennis Sädtler via ffmpeg-devel
2024-06-02 19:36   ` Martin Storsjö
2024-06-02 20:45     ` Dennis Sädtler via ffmpeg-devel [this message]
2024-06-03  7:51       ` Martin Storsjö
2024-06-03  9:38         ` Dennis Sädtler via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8a8cb94-ac6a-f914-36f3-05c9511593d9@obsproject.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=dennis@obsproject.com \
    --cc=martin@martin.st \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git