From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ABA344C9FF for ; Sun, 11 Aug 2024 18:27:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C47868DA3E; Sun, 11 Aug 2024 21:27:35 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 933FD68D9B5 for ; Sun, 11 Aug 2024 21:27:29 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-427fc97a88cso27642085e9.0 for ; Sun, 11 Aug 2024 11:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1723400849; x=1724005649; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=00Yf+oyvZ1uPI3VCGqZ4e721dQuF6p/mDClJBaeG7UQ=; b=Drg47Fs3xXDrCuBI+sHZAMZd79eObTG+eb/xfa3jDuzqWbtxmJBGOykFGLNilTBXCE br1nC5C85praHogE5QVXtT3hwKfXGZORV7IBKxQuRySZVY1VRHpuCGf8SBf2wR90sxMq TQuSyh1s8pFwCjAvDG7ZVjGyfoANufSKoA+gcUykvpaEr4JQXQqqgM3Ld1Jh876gbRWw vy4yPNMzXvv4tuTkxpkxkq6u3LjgBwJKdV7zmxDZjtPw5/SOGtjNBVBB0j9IudB7w9Zj pFX+QJxHu0m8NfZSUZSXxO3kzZYsPOK/9Arhq+OtQeyjF09Z4DxpgZze3zYs1d9N3Vwj /Znw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723400849; x=1724005649; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00Yf+oyvZ1uPI3VCGqZ4e721dQuF6p/mDClJBaeG7UQ=; b=XcLZC1SqSxh8eIhoqxDpJ3gH7jW4qxlY8JkRdBQ+i3FfG+AZ0my5+NbNaTAoH6r1Yc t4p9BatIey2X+lcH0Ihi7UJAonFNXmMy8nIiPAvqYAEVS/6WDb00W2O+LYREb87lBB9G wyrcf/II7pcHNtU5lDg+rzIKIOIkHPnKX4XRotuSDRtOISe1NZGIToT4iu7tUmG5wycN d7LvpNNg2ysQ4Gw+0qRKc6iuxXWEc5i9CiXHTF/09lle4BCXY0KW9XHDPsgUd8aGYiw9 dHcrCgzUlOG+yTERiE0mZkcyN9FtCKUOqOvz27QQI9xRvlROhvCmNrcVGMyA6wofVLX9 NJvA== X-Gm-Message-State: AOJu0Yx89qRocFkFhIW+wckmbh+RUTEjlVLVuG0+lrBQgtInuVDtYzSF b4QA/YTmdeeLvvfvVd65vYofi65EOt5iwDY3mr38/KDe6UZw1PdzjtlVnz1aMUsNlqtC8djNO/l 4 X-Google-Smtp-Source: AGHT+IHIENkArpCNKGq+3d7xEYqSPT1KmszSNMrqypyVNQhiYrg9wZXvd36tsOTFsrB17SFK1J0ENQ== X-Received: by 2002:a05:600c:3588:b0:426:647b:1bfa with SMTP id 5b1f17b1804b1-429c3a174c2mr52708365e9.8.1723400848008; Sun, 11 Aug 2024 11:27:28 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust955.5-4.cable.virginm.net. [82.13.67.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429c77374a5sm74732655e9.30.2024.08.11.11.27.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Aug 2024 11:27:27 -0700 (PDT) Message-ID: Date: Sun, 11 Aug 2024 19:27:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240730200235.1828384-1-David.Wu3@amd.com> From: Mark Thompson In-Reply-To: <20240730200235.1828384-1-David.Wu3@amd.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: > AV1Profile2 VAAPI is supported and tested on AMD VCN5. > > Signed-off-by: David (Ming Qiang) Wu > --- > libavcodec/av1dec.c | 3 +++ > libavcodec/vaapi_decode.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 1d5b9ef4f4..77f63661a0 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -599,6 +599,9 @@ static int get_pixel_format(AVCodecContext *avctx) > case AV_PIX_FMT_YUV420P12: > #if CONFIG_AV1_VULKAN_HWACCEL > *fmtp++ = AV_PIX_FMT_VULKAN; > +#endif > +#if CONFIG_AV1_VAAPI_HWACCEL > + *fmtp++ = AV_PIX_FMT_VAAPI; > #endif > break; > case AV_PIX_FMT_YUV422P: > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index a59194340f..a077e47326 100644 > --- a/libavcodec/vaapi_decode.c > +++ b/libavcodec/vaapi_decode.c > @@ -448,6 +448,9 @@ static const struct { > MAP(AV1, AV1_MAIN, AV1Profile0), > MAP(AV1, AV1_HIGH, AV1Profile1), > #endif > +#if VA_CHECK_VERSION(1, 23, 0) > + MAP(AV1, AV1_PROFESSIONAL, AV1Profile2), > +#endif > > #undef MAP > }; Based on this is supporting profile 2 only for 4:2:0 12-bit, and therefore can't advertise profile 2 generally for the decoder because that would imply support for all 4:2:2 and 4:4:4 cases as well. I think this wants something added to VAAPI in order to be able to advertise partial support for a profile? (It would be very confusing if we got "AV1Profile2" in VAAPI meaning only 4:2:0 12-bit and then have to add a separate "AV1Profile2exceptreallythistime" to meant actual AV1 profile 2.) Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".