Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb_neon: Implemented uyvytoyuv422
Date: Tue, 11 Feb 2025 23:53:07 +0200 (EET)
Message-ID: <d83b103b-f84d-28dd-2a9b-b4b96bce3bbd@martin.st> (raw)
In-Reply-To: <20250211213349.115386-2-ffmpeg@szaka.eu>

On Tue, 11 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote:

> I forgot to include the benchmarks in the previous message, here they
> are:
>
> A78:
> uyvytoyuv420_neon:                                    6112.5 ( 6.96x)
> uyvytoyuv422_neon:                                    6696.0 ( 6.32x)
> yuyvtoyuv420_neon:                                    6113.0 ( 6.95x)
> yuyvtoyuv422_neon:                                    6695.2 ( 6.31x)
>
> A72:
> uyvytoyuv420_neon:                                    9512.1 ( 6.09x)
> uyvytoyuv422_neon:                                    9766.8 ( 6.32x)
> yuyvtoyuv420_neon:                                    9639.1 ( 6.00x)
> yuyvtoyuv422_neon:                                    9779.0 ( 6.03x)
>
> A53:
> uyvytoyuv420_neon:                                   12720.1 ( 9.10x)
> uyvytoyuv422_neon:                                   14282.9 ( 6.71x)
> yuyvtoyuv420_neon:                                   12637.4 ( 9.15x)
> yuyvtoyuv422_neon:                                   14127.6 ( 6.77x)
>
> ---
> libswscale/aarch64/rgb2rgb.c      |  16 ++
> libswscale/aarch64/rgb2rgb_neon.S | 262 ++++++++++++++++++++++++++++++
> tests/checkasm/sw_rgb.c           |  63 ++++---
> 3 files changed, 318 insertions(+), 23 deletions(-)

Can you split out the checkasm changes to a separate preceding patch? That 
makes it easier to reason about it, regarding whether the new test 
coverage works for archs with existing asm, etc.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-02-11 21:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 19:06 Krzysztof Pyrkosz via ffmpeg-devel
2025-02-10 13:15 ` Martin Storsjö
2025-02-11 21:24   ` Krzysztof Pyrkosz via ffmpeg-devel
2025-02-11 21:33   ` Krzysztof Pyrkosz via ffmpeg-devel
2025-02-11 21:53     ` Martin Storsjö [this message]
2025-02-11 22:06       ` [FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_rgb: Added {yuyv, uyvy}toyuv{420, 422} test cases Krzysztof Pyrkosz via ffmpeg-devel
2025-02-11 22:06       ` [FFmpeg-devel] [PATCH 2/2] swscale/aarch64/rgb2rgb_neon: Implemented {yuyv, uyvy}toyuv{420, 422} Krzysztof Pyrkosz via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d83b103b-f84d-28dd-2a9b-b4b96bce3bbd@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=ffmpeg@szaka.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git