From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove hScale8To19_vsx
Date: Mon, 22 May 2023 10:45:04 +0300 (EEST)
Message-ID: <d7f6faa-7869-f9f5-afdb-ea4f34bcfb78@martin.st> (raw)
In-Reply-To: <NViuta7--B-9@lynne.ee>
On Thu, 18 May 2023, Lynne wrote:
> Fails checkasm on a Power9 DD2.2 02CY771 system.
> The assembly doesn't seem to have been independently tested at all.
>
> https://paste.sr.ht/~ky0ko/fe255ff73fab49b0c6d335437d894c1db626289e
>
> Patch attached.
FWIW, I don't know about the PPC functions, but... swscale in general is
quite complex on the inside, and the checkasm tests are quite rough
approximations (and are added much later than most of the functions); it's
possible that the tests are overly strict or otherwise wrong and check
things that don't matter in real use cases.
It's also possible that this function might be appropriate for cases when
SWS_ACCURATE_RND isn't set (when it's expected that the function rounds
differently than the C implementation).
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-22 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 12:52 Lynne
[not found] ` <NViuta7--B-9@lynne.ee-NViuxNy--3-9>
2023-05-20 18:38 ` Lynne
2023-05-22 7:45 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f6faa-7869-f9f5-afdb-ea4f34bcfb78@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git