From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 47AB7491BB for ; Wed, 6 Mar 2024 15:18:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E2F868CBED; Wed, 6 Mar 2024 17:18:03 +0200 (EET) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 991B768CB1D for ; Wed, 6 Mar 2024 17:17:56 +0200 (EET) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 47A642819FC8C for ; Wed, 6 Mar 2024 16:17:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1709738275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RwAbIQDA67o0kmXPqJWsuNLDZ0pg8GZX44LK83fOehA=; b=ErfgBk7PX9jn9qVeyudxOOTubJdJV+++nozeNsGqtGF5mkFE1nh3ICp2PIOWO3wm9qrV3o GmH4duRexcpWzuE/muM/Ki32nZYK7uV0vT/XoAHiNhPGFpQMY4nAdDm5s/WGclaH21nliE Y62VtCcg0d1xmX5dsIOWPfHBvmmgdL5a5VCkhrMGMGwFgr3nO6AGPiH19U+VCFD+grwveO YQCcRokI5xn71togXBeXDh2qTH95hDhuKyHPb923ZxelfxyjMbwZ3t1nl+9vjllP4koS4N ZabGUh5wFUkaZ0P/9Bex3fpWJg58OStHvG4dW6b4V88sgqqq8BnIeWY2duU9Jw== Message-ID: Date: Wed, 6 Mar 2024 16:17:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240306071913.2735832-1-marth64@proxyid.net> Content-Language: en-US, de-DE From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 06/03/2024 16:09, Stefano Sabatini wrote: > On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote: >> Since last iteration: removes unused variable in dvdclut.c >> >> Signed-off-by: Marth64 >> --- >> doc/demuxers.texi | 5 +++ >> libavformat/Makefile | 2 +- >> libavformat/dvdclut.c | 75 +++++++++++++++++++++++++++++++++++++++ >> libavformat/dvdclut.h | 37 +++++++++++++++++++ >> libavformat/dvdvideodec.c | 15 ++++++++ >> 5 files changed, 133 insertions(+), 1 deletion(-) >> create mode 100644 libavformat/dvdclut.c >> create mode 100644 libavformat/dvdclut.h >> >> diff --git a/doc/demuxers.texi b/doc/demuxers.texi >> index f4bac8f3b3..1a17c6db16 100644 >> --- a/doc/demuxers.texi >> +++ b/doc/demuxers.texi >> @@ -394,6 +394,11 @@ often with junk data intended for controlling a real DVD player's >> buffering speed and with no other material data value. >> Default is 1, true. >> > >> +@item clut_rgb @var{bool} >> +Output subtitle palettes (CLUTs) as RGB, required for Matroska. >> +Disable to output the palette in its original YUV colorspace. >> +Default is 1, true. > > Can you expand about this? When is matroska used in a DVD? Sounds to me like muxing _to_ matroska needs RGB palettes, but DVDs bring YUV ones. > Can we make the setting automatic in case matroska is detected? > > [...] > > LGTM otherwise. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".