From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] configure: Make nvenc select atsc_a53
Date: Wed, 5 Jan 2022 14:03:43 +0100
Message-ID: <d74c1b9f-a7c4-3046-7cab-9189c31d36ab@rothenpieler.org> (raw)
In-Reply-To: <PR3PR03MB6665176333AFAA4B13105D758F4B9@PR3PR03MB6665.eurprd03.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1163 bytes --]
On 05.01.2022 06:39, Andreas Rheinhardt wrote:
> It is the common code (that is compiled depending upon CONFIG_NVENC)
> that uses ff_alloc_a53_sei(), so it is natural to make nvenc itself
> select atsc_a53.
> This fixes compilation errors in case nvenc is enabled
> (e.g. autodected) with both nvenc-based encoders disabled.
> (This works in case of static linking (nothing pulls in nvenc.o),
> but it fails with shared builds.)
The correct way to do this would probably just be to stop building
nvenc.c when just nvenc is enabled, but instead move it to the two nvenc
encoders.
It being like it currently is mainly has historical reasons, as it
started out as single file encoder.
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> It would also be obviously desirable to disable nvenc if it is
> not needed if it is only autodetected and not explicitly enabled.
> Maybe it should even be unconditionally disabled if unused.
I don't think configure has any capability to do that? i.e. disable
flags that nothing uses?
But if both encoders are disabled, nvenc.c should not be built at all
anymore if changed as suggested above.
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4494 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-01-05 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 5:39 Andreas Rheinhardt
2022-01-05 13:03 ` Timo Rothenpieler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74c1b9f-a7c4-3046-7cab-9189c31d36ab@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git