From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D9361410B3 for ; Mon, 10 Jul 2023 20:27:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B387068C594; Mon, 10 Jul 2023 23:27:35 +0300 (EEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A24D868BF90 for ; Mon, 10 Jul 2023 23:27:28 +0300 (EEST) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6b750409beaso1066610a34.1 for ; Mon, 10 Jul 2023 13:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689020847; x=1691612847; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=AGrLs4KTFZTs/BDkHnwuLft76CmmS91Ru5EQXRmjEVM=; b=oWzpw5ED7Y1cEJIaRnDUK+is/uc5MdLsZthtwezby0ReRD/1REp7QkF7xED16rtLHn hUQQAe4qX3eTIBZ0fOUJGpF6AwxwX6Nyz3BXGsNZNyef8T1g+fQP7GQae6bKRCD3AAk3 duVhQJ1QWFOzktS3zBGLl3jKpwYTifJLvC+3y5djk/csS8+vQ8gqRghkSsXSoz/ACRmt TSMEuOP3kS6l53cqVBPJHCFHlN1e3esfis43JK2fmJXglcg3F1BkZvPDTq4NjQP8G866 J/SUB7s1omg0Ong16plNXju0KST5otgIWtecB2u+NboNhd4inmCgVj/CLrPMbELLDLUp jRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689020847; x=1691612847; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AGrLs4KTFZTs/BDkHnwuLft76CmmS91Ru5EQXRmjEVM=; b=QRqe499AITqiwKts8Gk+lFz5ELWNtM07cuCTU3qfLHf4V2AhWwgA1IyVdrkeNJAbdn pHgVwfp5OmXnUrqZWBH6if8d1m5bMP2K3YbDMQ+ApgMj/D5X+s9CxzePmYXzee/rsCqW qD/S2br4lwNAaX7omM/RPdvaKua/NSZCr6My7V18XEQL3NjNnQJLrhdmFRAYPMx5w01b 8GywXOx4Lk+jojeon1qSHq59sPSnTNvVHQxNEe7miFfDJQZx77S/juYogGbOGD0IuntG yEwyI+CqRaGKcIzPJaA3hE4JDM4hJUvCwoxhkeRi8VFUapffWp27633lBmkVjOdj7krV 5ByA== X-Gm-Message-State: ABy/qLasubvWCxSk8H+kGUgQQvyDul7fkq03Btmm52A34b+RjwDjSZJK dWSGVLq8KChjHv8QnGPoIKPUzncdnJY= X-Google-Smtp-Source: APBJJlHfIQWVeRc8G1APUUnng8jd7BqS66dBaQcI+oscfgscRaki87GMq7KyAI4KPS6K8mVwUm2d/Q== X-Received: by 2002:aca:e145:0:b0:39e:86b3:d8ab with SMTP id y66-20020acae145000000b0039e86b3d8abmr8489153oig.4.1689020846695; Mon, 10 Jul 2023 13:27:26 -0700 (PDT) Received: from [192.168.1.35] (c-98-224-219-15.hsd1.mi.comcast.net. [98.224.219.15]) by smtp.gmail.com with ESMTPSA id t7-20020a815f07000000b005773ca61111sm168863ywb.42.2023.07.10.13.27.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 13:27:26 -0700 (PDT) Message-ID: Date: Mon, 10 Jul 2023 16:27:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: <20230708184502.66917-1-leo.izen@gmail.com> <9262e3b3-8851-de22-7980-2e8d4985f185@gmail.com> Content-Language: en-US-large From: Leo Izen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/8/23 23:44, Gyan Doshi wrote: > > > On 2023-07-09 01:00 am, Leo Izen wrote: >> On 7/8/23 15:25, Gyan Doshi wrote: >>> >>> >>> On 2023-07-09 12:15 am, Leo Izen wrote: >>>> Git master libjxl changed several function signatures, so this commit >>>> adds some #ifdefs to handle the new signatures without breaking old >>>> releases. >>> >>> Same objection as to the patch submitted a few days ago, pasted below: >>> >>> ---- >>> 0.9.0 is still unreleased and unfortunately the API change wasn't >>> accompanied with a version bump. >>> >>> The API changes were pushed on Jun 21st and the version bump to 0.9.0 >>> was pushed on Jan 12th. >>> So this will still break compilation with older git checkouts of >>> libjxl. Ideally libjxl should bump once more to 0.9.1 >>> ---- >>> >>> Regards, >>> Gyan >>> >> >> Oh, I missed that patch. >> >> In either case, why do we care about breaking old development versions >> that aren't releases? > > Ok. Just make a note in the commit msg then. > > Regards, > Gyan > Noted. I pushed as 75b1a555a70c178a9166629e43ec2f6250219eb2 with a slightly amended commit message. - Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".