Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9

[Leo Izen <leo.izen@gmail.com>]

On 7/8/23 23:44, Gyan Doshi wrote:
> 
> 
> On 2023-07-09 01:00 am, Leo Izen wrote:
>> On 7/8/23 15:25, Gyan Doshi wrote:
>>>
>>>
>>> On 2023-07-09 12:15 am, Leo Izen wrote:
>>>> Git master libjxl changed several function signatures, so this commit
>>>> adds some #ifdefs to handle the new signatures without breaking old
>>>> releases.
>>>
>>> Same objection as to the patch submitted a few days ago, pasted below:
>>>
>>> ----
>>> 0.9.0 is still unreleased and unfortunately the API change wasn't 
>>> accompanied with a version bump.
>>>
>>> The API changes were pushed on Jun 21st and the version bump to 0.9.0 
>>> was pushed on Jan 12th.
>>> So this will still break compilation with older git checkouts of 
>>> libjxl. Ideally libjxl should bump once more to 0.9.1
>>> ----
>>>
>>> Regards,
>>> Gyan
>>>
>>
>> Oh, I missed that patch.
>>
>> In either case, why do we care about breaking old development versions 
>> that aren't releases?
> 
> Ok. Just make a note in the commit msg then.
> 
> Regards,
> Gyan
> 

Noted. I pushed as 75b1a555a70c178a9166629e43ec2f6250219eb2 with a 
slightly amended commit message.

- Leo Izen

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".