From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7197E44637 for ; Sun, 20 Nov 2022 11:50:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2866B68A360; Sun, 20 Nov 2022 13:50:07 +0200 (EET) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9604C68BA43 for ; Sun, 20 Nov 2022 13:50:00 +0200 (EET) Received: by mail-ot1-f53.google.com with SMTP id cn2-20020a056830658200b0066c74617e3dso5835905otb.2 for ; Sun, 20 Nov 2022 03:50:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=seApqNl9wEeLkpYDwanbvjzuNo+mBXsxurN4/l5Cw0c=; b=hJGWzTYWZe1AM0XewJHsoXcf0Yxx7LpvUbHLtC6Qu/qdQ55ZREZjacmqCeFOskqlBL RHeqfmLzRXjlh0olW8EQOWB7K+uO3hv3AaLGZrnb/RkSF+SA9atKTwfIl6LtHe8zLfHM P573env29uU318l94CL0NO3htDrIxf73BwnRZK8Tt1hs66Ig7k9mAnHTilnvnfOhLF8M PTxmHEkFl2G2YA0aJz2dNuTF6awjPrbPuD51RDbtoUsawH7QAn9FtpvwqH/s5oiyxLlG h4Fl5a4ZNLrtHslhcwTcj9vl1IT8o+1/N0PNz8qnhT0oBqLQnAqFBQVp/Xrx2AFSR9B/ yn+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=seApqNl9wEeLkpYDwanbvjzuNo+mBXsxurN4/l5Cw0c=; b=3VliYJPrksKkCOCWI2inmYuHZg1gYi+AIXTJogSIcGWB/GEoL4CMMJdg4OPMhMc9UR V9umO0FeUewOE4RCz5dFa9rksBeIyRjPEvmI4RIxV2utgTJwmpu4cjz1hJ8FEmjPzyNu qCZvhngDcoM5CyELEQF9t9gkdHJ40M5k+8dMquZ7pu2M/mr2IQ3np5fgYAeC4JQYG9OI Sw7jsBTaEaWtRIHdnUV4nw5fPKtM95cnk8b5CYxaulKBBmGIu+CT8SQ8eJsDWFMDjfD/ IRxUzh/yLZGwKaWvcLWNYnYyXWfLcGv0zP/2Rrizvb7nBb43XhyhIB/g9O/0dGVNjlwg lnBg== X-Gm-Message-State: ANoB5plXBIzOJc+AoW3REsLTvvmQLJ0ZwEiWPDABvUw4lCGfPfx2119E 1/UFH7vq/Yt2CyL4qOPiq0K85QLDG0Y= X-Google-Smtp-Source: AA0mqf4Qo2rG3d8E39eNctTaDoY5N2SA+O43oM+ZeNJnDQH7vODTAYf/5WsQrQt3TequyNz3BYkSXw== X-Received: by 2002:a05:6830:18ed:b0:66d:df61:a2a2 with SMTP id d13-20020a05683018ed00b0066ddf61a2a2mr2776156otf.314.1668944998220; Sun, 20 Nov 2022 03:49:58 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id n9-20020a056870558900b0013669485016sm4657900oao.37.2022.11.20.03.49.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 03:49:57 -0800 (PST) Message-ID: Date: Sun, 20 Nov 2022 08:50:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: ffmpeg-devel@ffmpeg.org References: <20221120023350.1684083-1-ccom@randomderp.com> Content-Language: en-US From: James Almer In-Reply-To: <20221120023350.1684083-1-ccom@randomderp.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: guard against bit_rate being zero X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/19/2022 11:33 PM, Christopher Degawa wrote: > division by zero occurs if it's not specified > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 48cd58a0b3..06874dfa63 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -179,7 +179,9 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > param->min_qp_allowed = avctx->qmin; > } > param->max_bit_rate = avctx->rc_max_rate; > - param->maximum_buffer_size_ms = avctx->rc_buffer_size * 1000LL / avctx->bit_rate; > + param->maximum_buffer_size_ms = avctx->bit_rate > + ? (avctx->rc_buffer_size * 1000LL / avctx->bit_rate) > + : 0; The documentation for maximum_buffer_size_ms says minimum value is 20. > > if (svt_enc->crf > 0) { > param->qp = svt_enc->crf; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".