From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3C4FD4BB74 for ; Fri, 1 Aug 2025 06:05:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 93ECC68CFC7; Fri, 1 Aug 2025 09:04:55 +0300 (EEST) Received: from send37.i.mail.ru (send37.i.mail.ru [89.221.237.132]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 42B3E68C99F for ; Fri, 1 Aug 2025 09:04:48 +0300 (EEST) Received: by exim-smtp-7fdd5bdf48-dr9fp with esmtpa (envelope-from ) id 1uhiso-00000000H38-182F for ffmpeg-devel@ffmpeg.org; Fri, 01 Aug 2025 09:04:46 +0300 Content-Type: multipart/mixed; boundary="------------Vrn9kO9RdYYT6iRSb0Wj0TFo" Message-ID: Date: Fri, 1 Aug 2025 11:04:44 +0500 MIME-Version: 1.0 User-Agent: Icedove Daily To: ffmpeg-devel@ffmpeg.org References: <20250731141914.GS29660@pb2> Content-Language: en-US In-Reply-To: <20250731141914.GS29660@pb2> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A251A5C1AEB1B7127AE35E08C2092981C47FEF232490065F182A05F538085040E213AFDDDB12B06F3DE06ABAFEAF670500F21BBDC3775D0CE82B63BFB18DABB8C94F5D657025D6F1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74EB183AD45C8BEFBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D5B197C6EC5B4BE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B267EE2E472D5307A72E070BE324C7D3C4D9325935A326AF1DBB0A4F435E46E6718B35066C979671628AA50765F7900637FE0C267D7D9174FA389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22497ECBC18655D52CDF76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BB9CEE4F2B4A90F843AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4936B11289E5FFCCAECE5B2F3A2B87CD4C8C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C572FF52A5EAA2D75002B1117B3ED69669800D5BDB2C689DED71F038FC046993823CB91A9FED034534781492E4B8EEAD643C8550F8485502BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7161D15182FF9C9CFD424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B7CBFF60649FF266B4B81899C82E821C657148DE67799828BFFCCA5910A65658DBD42307D93246371D7E09C32AA3244C8608CCB90BC7F4B177DD89D51EBB774297712510021C93F6EA455F16B58544A2C99F59F2F009F0963871D1C702CBDB0A0ADD6335840D67A2F0A6D2C91ED28CB6 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVUlTLJrxaS1uKBSqp4qDYfo= X-Mailru-Sender: 811C44EDE0507D1FAF09668A4CA9AED77E40A3B55D96FC0F8BD48BD36611AD3411D58EAB139A1DEAC791B84A9425D507AE612CA5628006519D05D10692C02F823DDAF8CF51E8EB1316F5670CE7ACBB318BCC081D9D5610F3BE6FBB40ADBE433113D393D611A7C5823DDE9B364B0DF289AE208404248635DF X-Mras: Ok Subject: Re: [FFmpeg-devel] [PATCH] libopenmpt: fix seeking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: kimapr via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: kimapr Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------Vrn9kO9RdYYT6iRSb0Wj0TFo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit revised the patch, hopefully it's better now. i also fixed another weirdness that i didn't fix in the original patch On 2025/07/31 19:19, Michael Niedermayer wrote: > while your email contains quite some details, the commit message of > just "libopenmpt: fix seeking" is too terse added some details! > is there any possibility of a "unknown" "position" ? > if not its fine otherwise a check may be needed to handle that no idea. openmpt docs don't mention the possibility, and besides like returning a NaN there isn't really much the API can do to indicate such a condition > is it possible that this exceeds the int64_t range ? > if so these out of range values should probably be replaced by AV_NOPTS_VALUE seems unlikely! i added a check anyway though (should also catch the unknown position if it is indicated by a NaN). rather than replacing the value with AV_NOPTS_VALUE i just don't set it. Is that good? --------------Vrn9kO9RdYYT6iRSb0Wj0TFo Content-Type: text/x-patch; charset=UTF-8; name="0001-libopenmpt-fix-seeking-weirdness.patch" Content-Disposition: attachment; filename="0001-libopenmpt-fix-seeking-weirdness.patch" Content-Transfer-Encoding: base64 RnJvbSBkNjQxOGI2NjVjYzgwYTE2ODBhZmVlODI1OWEyNDJhNDJjMGVkMmFkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLaW1hcHIgPGtpbWFwci5mckBnbWFpbC5jb20+CkRh dGU6IE1vbiwgMjggSnVsIDIwMjUgMDY6MzI6MjcgKzA1MDAKU3ViamVjdDogW1BBVENIXSBs aWJvcGVubXB0OiBmaXggc2Vla2luZyB3ZWlyZG5lc3MKCi0gcHJvcGVyIHB0cyBmb3IgcGFj a2V0cy4gbGVhdmluZyBpdCBibGFuayBsZWF2ZXMgaXQgdXAgZm9yIGd1ZXNzaW5nLAogIGJ1 dCB0aGUgZ3Vlc3MgZG9lc24ndCB0YWtlIHNlZWtpbmcgaW50byBhY2NvdW50LCBjYXVzaW5n IHdlaXJkbmVzcy4KCi0gY2xhbXAgdG8gMCB3aGVuIHNlZWtpbmcgdG8gbmVnYXRpdmUgdHMu IGxpYm9wZW5tcHQgZG9jcyBhcmUgdW5jbGVhciBvbgogIHRoaXMgYnV0IG5vdCBkb2luZyB0 aGlzIGNhdXNlcyBhbiBpbW1lZGlhdGUgRU9GIHdoZW4gc2Vla2luZyBiYWNrd2FyZHMKICB0 byB0aGUgYmVnaW5uaW5nIGluIG1wdi4KCi0gb25seSBzZXQgc29uZyBkdXJhdGlvbiBhbmQg cGFja2V0IHB0cyB3aGVuIHRoZXkgYXJlIG5vbi1uZWdhdGl2ZSBhbmQKICBpbiBpbnQ2NCBy YW5nZS4gTmFOcyBjb3VudCBhcyBvdXQgb2YgcmFuZ2UuIHRoaXMgaXNuJ3QgYSBmaXggZm9y IGFueQogIHNwZWNpZmljIGlzc3VlIGJ1dCBtaWdodCBiZSBoZWxwZnVsIHN0aWxsLCBhbmQg c2hvdWxkbid0IGJyZWFrCiAgYW55dGhpbmcuCi0tLQogbGliYXZmb3JtYXQvbGlib3Blbm1w dC5jIHwgMTIgKysrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpYmF2Zm9ybWF0L2xpYm9wZW5tcHQu YyBiL2xpYmF2Zm9ybWF0L2xpYm9wZW5tcHQuYwppbmRleCAzY2E1OWY1MDZmLi5hYjYxMDAw ZDBhIDEwMDY0NAotLS0gYS9saWJhdmZvcm1hdC9saWJvcGVubXB0LmMKKysrIGIvbGliYXZm b3JtYXQvbGlib3Blbm1wdC5jCkBAIC0xNDcsNyArMTQ3LDEwIEBAIHN0YXRpYyBpbnQgcmVh ZF9oZWFkZXJfb3Blbm1wdChBVkZvcm1hdENvbnRleHQgKnMpCiAgICAgaWYgKCFzdCkKICAg ICAgICAgcmV0dXJuIEFWRVJST1IoRU5PTUVNKTsKICAgICBhdnByaXZfc2V0X3B0c19pbmZv KHN0LCA2NCwgMSwgQVZfVElNRV9CQVNFKTsKLSAgICBzdC0+ZHVyYXRpb24gPSBsbHJpbnQo b3Blbm1wdC0+ZHVyYXRpb24qQVZfVElNRV9CQVNFKTsKKworICAgIGlmIChvcGVubXB0LT5k dXJhdGlvbiAqIEFWX1RJTUVfQkFTRSA8PSBJTlQ2NF9NQVggJiYKKyAgICAgICAgb3Blbm1w dC0+ZHVyYXRpb24gKiBBVl9USU1FX0JBU0UgPj0gMCkKKyAgICAgICAgc3QtPmR1cmF0aW9u ID0gbGxyaW50KG9wZW5tcHQtPmR1cmF0aW9uKkFWX1RJTUVfQkFTRSk7CiAKICAgICBzdC0+ Y29kZWNwYXItPmNvZGVjX3R5cGUgID0gQVZNRURJQV9UWVBFX0FVRElPOwogICAgIHN0LT5j b2RlY3Bhci0+Y29kZWNfaWQgICAgPSBBVl9ORShBVl9DT0RFQ19JRF9QQ01fRjMyQkUsIEFW X0NPREVDX0lEX1BDTV9GMzJMRSk7CkBAIC0xNzAsNiArMTczLDggQEAgc3RhdGljIGludCBy ZWFkX3BhY2tldF9vcGVubXB0KEFWRm9ybWF0Q29udGV4dCAqcywgQVZQYWNrZXQgKnBrdCkK ICAgICBpZiAoKHJldCA9IGF2X25ld19wYWNrZXQocGt0LCBBVURJT19QS1RfU0laRSkpIDwg MCkKICAgICAgICAgcmV0dXJuIHJldDsKIAorICAgIGRvdWJsZSBwb3MgPSBvcGVubXB0X21v ZHVsZV9nZXRfcG9zaXRpb25fc2Vjb25kcyhvcGVubXB0LT5tb2R1bGUpICogQVZfVElNRV9C QVNFOworCiAgICAgc3dpdGNoIChvcGVubXB0LT5jaF9sYXlvdXQubmJfY2hhbm5lbHMpIHsK ICAgICBjYXNlIDE6CiAgICAgICAgIHJldCA9IG9wZW5tcHRfbW9kdWxlX3JlYWRfZmxvYXRf bW9ubyhvcGVubXB0LT5tb2R1bGUsIG9wZW5tcHQtPnNhbXBsZV9yYXRlLApAQCAtMTk1LDYg KzIwMCw5IEBAIHN0YXRpYyBpbnQgcmVhZF9wYWNrZXRfb3Blbm1wdChBVkZvcm1hdENvbnRl eHQgKnMsIEFWUGFja2V0ICpwa3QpCiAKICAgICBwa3QtPnNpemUgPSByZXQgKiAob3Blbm1w dC0+Y2hfbGF5b3V0Lm5iX2NoYW5uZWxzICogNCk7CiAKKyAgICBpZiAocG9zID49IDAgJiYg cG9zIDw9IElOVDY0X01BWCkKKyAgICAgICAgcGt0LT5wdHMgPSBsbHJpbnQocG9zKTsKKwog ICAgIHJldHVybiAwOwogfQogCkBAIC0yMTEsNiArMjE5LDggQEAgc3RhdGljIGludCByZWFk X2Nsb3NlX29wZW5tcHQoQVZGb3JtYXRDb250ZXh0ICpzKQogc3RhdGljIGludCByZWFkX3Nl ZWtfb3Blbm1wdChBVkZvcm1hdENvbnRleHQgKnMsIGludCBzdHJlYW1faWR4LCBpbnQ2NF90 IHRzLCBpbnQgZmxhZ3MpCiB7CiAgICAgT3Blbk1QVENvbnRleHQgKm9wZW5tcHQgPSBzLT5w cml2X2RhdGE7CisgICAgaWYgKHRzIDwgMCkKKyAgICAgICAgdHMgPSAwOwogICAgIG9wZW5t cHRfbW9kdWxlX3NldF9wb3NpdGlvbl9zZWNvbmRzKG9wZW5tcHQtPm1vZHVsZSwgKGRvdWJs ZSl0cy9BVl9USU1FX0JBU0UpOwogICAgIHJldHVybiAwOwogfQotLSAKMi40OS4wCgo= --------------Vrn9kO9RdYYT6iRSb0Wj0TFo Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------Vrn9kO9RdYYT6iRSb0Wj0TFo--