Re: [FFmpeg-devel] [PATCH 2/2] swscale/swscale_unscaled: avoid nv12 <-> nv21 bug

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/swscale_unscaled: avoid nv12 <-> nv21 bug
Date: Sun, 16 Mar 2025 12:02:19 -0300
Message-ID: <d689cf15-e7f7-4fab-b235-b272d4e1a866@gmail.com> (raw)
In-Reply-To: <20250316125224.7616-2-ffmpeg@haasn.xyz>

[-- Attachment #1.1.1: Type: text/plain, Size: 1052 bytes --]

On 3/16/2025 9:52 AM, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> This is not handled by the planar copy wrapper, so exclude it.
> ---
>   libswscale/swscale_unscaled.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c
> index 1df160daaa..4959963b18 100644
> --- a/libswscale/swscale_unscaled.c
> +++ b/libswscale/swscale_unscaled.c
> @@ -2660,7 +2660,8 @@ void ff_get_unscaled_swscale(SwsInternal *c)
>           (isPlanarYUV(srcFormat) && isPlanarYUV(dstFormat) &&
>            c->chrDstHSubSample == c->chrSrcHSubSample &&
>            c->chrDstVSubSample == c->chrSrcVSubSample &&
> -         isSemiPlanarYUV(srcFormat) == isSemiPlanarYUV(dstFormat))))
> +         isSemiPlanarYUV(srcFormat) == isSemiPlanarYUV(dstFormat) &&
> +         isSwappedChroma(srcFormat) == isSwappedChroma(dstFormat))))
>       {
>           if (isPacked(c->opts.src_format))
>               c->convert_unscaled = packedCopyWrapper;

LGTM.

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".