From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 230484716F for ; Sat, 9 Mar 2024 02:18:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1096468CFDA; Sat, 9 Mar 2024 04:18:37 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B2D916802E2 for ; Sat, 9 Mar 2024 04:18:30 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 5C437E9F97 for ; Sat, 9 Mar 2024 03:18:30 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K6ehlnuvRHXW for ; Sat, 9 Mar 2024 03:18:28 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id EDA4DE9947 for ; Sat, 9 Mar 2024 03:18:27 +0100 (CET) Date: Sat, 9 Mar 2024 03:18:27 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <95f16ad5-dd52-43fb-b9b4-d428ef6c7282@gmail.com> Message-ID: References: <20240308201359.3013-1-cus@passwd.hu> <95f16ad5-dd52-43fb-b9b4-d428ef6c7282@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 8 Mar 2024, James Almer wrote: > On 3/8/2024 5:13 PM, Marton Balint wrote: >> Signed-off-by: Marton Balint >> --- >> libavformat/mxfdec.c | 129 ++++++++++++++++++------------------------- >> 1 file changed, 53 insertions(+), 76 deletions(-) >> >> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c >> index 289db9833c..e2f4a22983 100644 >> --- a/libavformat/mxfdec.c >> +++ b/libavformat/mxfdec.c [...] >> + ret = av_channel_layout_retype(ch_layout, AV_CHANNEL_ORDER_NATIVE, >> AV_CHANNEL_LAYOUT_RETYPE_FLAG_LOSSLESS); >> + if (ret == AVERROR(ENOSYS)) >> + ret = av_channel_layout_retype(ch_layout, >> AV_CHANNEL_ORDER_UNSPEC, AV_CHANNEL_LAYOUT_RETYPE_FLAG_LOSSLESS); >> + if (ret < 0 && ret != AVERROR(ENOSYS)) >> + return ret; >> >> return 0; >> } > > I'm not against this patch, but shouldn't we make sure for example that swr > supports custom layouts first? I don't really know what is the best approach here. Sure, some stuff will break if it encounters a custom layout. But nobody will fix it, if no custom layouts are ever encountered... Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".