From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DCFF9451FC for ; Thu, 12 Jan 2023 05:42:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 701AC68BD08; Thu, 12 Jan 2023 07:42:02 +0200 (EET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D77F68BA2D for ; Thu, 12 Jan 2023 07:41:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673502121; x=1705038121; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=x/Pm96fJPoO300+axjfTdnJe+jo9BnUQIzxlxLW8Rqk=; b=G25/QYCyHaaWbKZTmG7AOjaSklSMvRX+lfyx4llnRn4meyfkl914ALNg I+Yw/SDD3E9HwSj1t1jzhIloGah44lypdkT9gmR1IIkCWM0XDnLMWe58B ffofAnKDYDwjhbtZ8dgPaAPbM7nxS00OYipH1TSs9fMHn3umxzWGyv8ES RF7VkDcN6CnYR/JvJZIHMeWqibPBAyaekchH5VTdFOZ04UznXTiWLdBMM UqbPJJyrYJ+K4qN3bk6/zihiZX2nWbiKmZq62QG0cXu9yXe8sfX7S1ZMk GWt1IdXFTB9O082zEEfd57a5eJVKQ0MBCPaQMpkCfMWYdYaqiDQNSI2wA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="323682200" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="323682200" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 21:41:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="720974301" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="720974301" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 11 Jan 2023 21:41:54 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 21:41:53 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 21:41:53 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 21:41:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EjdPe9Awyaw3ssBFlWCZIYS9MooDWaRJS3Fnop/OK/95gE7TnNDYoZaIsqJXg9lAx+Hxw4tZBwJdCVF3s0EhtTZDc+MDdHYsIVk5HOL60ph6bj0R2n0J24irJbDl2fhgsP7D661d6IRiU8JKX7b+Ryjb4xaAFvfKQiwEZXkcr5Qj0HEbcAUCXDjAlWhqYflNOSDBkChAhcafjjYr2p09YzVIfcuVpyME7az/UNfL21GqjUoBieebSlt0RnIq+/+7t3oO0SQ8YDOPjHroVFbZHO+sQjUhuPzal0wXyb8qQSnhZ251j803tqLzaEwiGULzi1o/sAZR77XTgGpxSsZoHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/Pm96fJPoO300+axjfTdnJe+jo9BnUQIzxlxLW8Rqk=; b=fqGrLbysD0a4CBYdHPliakVSUnSmemSPAeWJQYH4s+TMteyVrICz4qnlJSd/gyeF7Zq26x+LmaUDn/W+o1Dr9m4sGXsZA8K265LeX2uC+9M+UqFDN3cxq6DjLin4A0GK6IBdF3wq8qb5jIwCRsRvpjUNOPW4IVkQ+6FPmcLySHAA9xk+3i4jtXx8gpSLaK/RcQX1oJ1Aqyl5VpZWAwTmiIHoBZvKR7GIV5rt6zLMHL0HGz3skvfLa8RMxEiB1zU0lm7G1okV/yrna3AQkInv9Nm0Dn5us5PeazxT5llq0I/0JrfJf1bZzSIs8cNPX7NF9vl+Xr/jti66TAvwAtdrOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5507.namprd11.prod.outlook.com (2603:10b6:610:d6::8) by SJ0PR11MB5866.namprd11.prod.outlook.com (2603:10b6:a03:429::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 05:41:46 +0000 Received: from CH0PR11MB5507.namprd11.prod.outlook.com ([fe80::98e2:ba9:2c1a:8c6e]) by CH0PR11MB5507.namprd11.prod.outlook.com ([fe80::98e2:ba9:2c1a:8c6e%4]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 05:41:46 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 4/8] lavfi/vf_vpp_qsv: add vpp_preinit callback Thread-Index: AQHZJjvfv/Mn8ZTfxUC9FD2VnpqyUK6aNL0AgAABOQCAAA6tAA== Date: Thu, 12 Jan 2023 05:41:45 +0000 Message-ID: References: <20230109071210.1829699-1-haihao.xiang@intel.com> <20230109071210.1829699-4-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5507:EE_|SJ0PR11MB5866:EE_ x-ms-office365-filtering-correlation-id: ef7792fc-1b63-4fc9-715c-08daf45fb147 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M4zwlqHnyRNePRb3PDyuJS9qaenb0zohmDJwf54l56x0BSu2zA9bRzGHFbxcdn6ljDj+cKW0jPgDtvQJUEnSzN/gmKnp2Cfk36WD8njGwJtsPCDtVXCFKFo+/gFgupuYK2PNMTOnEru3NL8BLQrbbsHhM2R/7zGC5sdalp07vhYO5T1Fsza/guBa1+DGBlggvS1eCIaTxNGF6DPm19vHRr2OGDt7Yz7PR+B/sSKZcwSVYozElOvlfCIbLlmAi5uHIFCkv9tv19G7nX9VhqEtwPahwyMw5QZ24m9wmv1tZ/Mm76q5qEwAFJO/i3dPoQ7eO7UdgPK+AU/AKJqK+IIXVKlnOEhZ81C9yp3tfzcaLnfo0KuYJ1+TytwL0nqIDYABUNk5Qym+uM9gvsIV0ZzVCEnGtbpB9xL6GXZDzWT6qU1VxktCGeY/kzUdylX7GF9fP0Oo51r+Woe5d09pRlC6Kej4k5pJM/9Ili2Kqbjb1mqtfYrEaP9axOz3Zb8/U5RxTbvEhWbv/XK/Vv8mDT34iOI2jrI7gCWHutHvHGeXzvnxFFxEMJQvoJ1HZqJCFrI77rH0ET59TT4xXoQWXHpAjC2+cR5FuVqzwxhWZ7yCk8nnv/K4BvGmeh7LiZuU1aRqUhwzZtsVoyPO5F8boM+n4yxuQ+vtVvoqhkcgF+kuVOMIsVUy3mWY841A9CT17NMSisxSBRh9jtgdvDdt7igespYoDLO+VeZh2lGj3BMb0Y8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5507.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199015)(83380400001)(122000001)(82960400001)(2906002)(5660300002)(8936002)(41300700001)(316002)(478600001)(6506007)(8676002)(38100700002)(966005)(186003)(6486002)(2616005)(66476007)(6916009)(6512007)(64756008)(26005)(66446008)(71200400001)(86362001)(66946007)(91956017)(66556008)(66899015)(38070700005)(76116006)(36756003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dVJETTRBZVhvSzBkb3hBdlpwZGsrVUh1YzJwL2xldU5xL3IrbTZrR05MK1NU?= =?utf-8?B?R0lrNlZvSXc5MHRKcHlLRi9CWkxRUUdtWHJ2d3RDd0JEUXhuWkJQSnlrSjhl?= =?utf-8?B?a1hmUWdHQUNJSjVlRFpyWWpNY0dlMitoQUY4T0VoaVdQRENTSVEvRStYbHZX?= =?utf-8?B?OFIyU2ZSTGJwMTBMVG5lQUhZVlFyYWVRRCttSS9BM3NrSm9hREhJemc5ZGdJ?= =?utf-8?B?VEF0MWVjK1BVQ3UvekJSczVWYURFQ1JKRE9JQVI5VG52ejAxSWEya1lCM0ds?= =?utf-8?B?S0tPUklBNDFrVGpVYnlUTmNvZTk0c3UzNThFSU5JdytlalNCY3c3Wng3cDEv?= =?utf-8?B?SGZPQUd3RmRKSGJWdGVwRFF5VlZ4UkFJYk9wdmF1dUJhMTQ5d0FFejNCWVNk?= =?utf-8?B?YlVaTGNhVWw3WVU3U0tjYjJ2SHJlVjJDRDNkQyt6YWhwNnpZQWwxUWxXMTBW?= =?utf-8?B?SlpnT1I4NkQ2NHBxT2xuSlUzRW1uaER0bVovdzhBS2NYYVdqcXZKemo4RENk?= =?utf-8?B?aWJZRWgreFFRQWFlbkdlSFJtNXNzYzJGd1pTS2JxcFE0RGJZZ1I4VmFOKzZ3?= =?utf-8?B?VXIwYXcrN3JUUFFYMWZLSEFwd1QrTlJyOURqclFacXUvMEpSNnpIc0ZyZ0Rl?= =?utf-8?B?YU5lMHhGanhZK1NXUitlOU50WUpmeGdQTTl5TDJGbDh3dDkxQUNiVnpYOU9W?= =?utf-8?B?M0tySlhreXM3ZWRmMENrVEU3MTViaE9vdjJoQ1BxMU8rR0F3WkpSdEswdHdC?= =?utf-8?B?MVpmb0UzU2lkL0FnaDZXZTYvVk5FMitQeGc5OERXUTZFd2kzVkQ0WGcrbVlX?= =?utf-8?B?aGhYY0JIR2RkVkhQUnJvcmZmNHZIeUxuVWlxenJmMWtmMnNDblpFTkU4Mlo4?= =?utf-8?B?bmJCN0IxTXhhSERjVnVkZWhkMk5SUjVGOWFQdWJaQnB1WUVFYVQ4RCtyTXha?= =?utf-8?B?TlZ3OGcxSTJHUENWRkc5QWtkaW1WTzVndHBVUWZHcklHSmJXckJ6bDlmQkZV?= =?utf-8?B?Znorbyt2Vlg1bWZOb1N1QmFlYWthMUk4NHd1K2NuRDBKeUpkUWU2ZmpRdllB?= =?utf-8?B?T2RzU3c1VjAzNHgrMXV5d0g1bWQvTlBrVzVzWHc1VXRXSVYzajVtTWdDVmtr?= =?utf-8?B?VTVqa2ZzSk9xY0xEcFl6UmtXOFNadnpVd3VhUUtsY1BSelFpWXkrUnZqbGVI?= =?utf-8?B?TTJxVjRnckl4eGFxRlNVenA3TCsxbUJCQ1NkNTB6R01GMndjd2pxczNnUFhj?= =?utf-8?B?d254elp0QWFRUEhDTFBQNUg2cjRIc2ZQcDdqZWFmT05PS2ZKMFczc2NCUDRS?= =?utf-8?B?Qk80dlpzY2k3Vk5heEgrTVc4alNaWlowUEhheWV4NGptNWljam5mUm0vbmN1?= =?utf-8?B?dkN4ZFFiY3Zyb1hXdTN6K1FpL25BWHIybm9pc1hHZEZnN0U3Uy9FODBWOVNz?= =?utf-8?B?Y0ptSzFtZ0xXUlN2blZaTlpQN24vRVBPRDVwODl2QTQ3VGFYZ2M3ZHdockkw?= =?utf-8?B?YmxIRXgrajJMczZBYTBWcmkxWFExZWd2MWhBNzBOVXlvbWNjTTR5OThOYkNs?= =?utf-8?B?RXZhNlpWL1ppWU9EbC85eEoyeTdjekpOa29NME9vRlY4RjJrdkQrSGJSemhj?= =?utf-8?B?aUZONjZEVWV6ZzMyTmt6QXN3YVhVRVZZK3E5Rk15d0FDVHBGSmJsOE1BM1lQ?= =?utf-8?B?WmdIcGhHV0dSYjNsVTRycHNoMU5qMXFtMzFZNVUyNzMwa0NUQW4zZlh1ekpN?= =?utf-8?B?dklvdVhuMWlOU2M5czBnZXY1anJKeXFTNXlYRlNCL1pJRWlpRnVhS3gydEVZ?= =?utf-8?B?aitmNjM1UjJZSE92dWdVNlcrSlhDWm5sUjZ3Mk8yQ244SG94M2Zwd0JqU3Zm?= =?utf-8?B?QWV0WVBtL0xIV09DZXRvUFNLOFdKYklpV282WkFLbDFhZUFPd1NhUm44Q3lS?= =?utf-8?B?SDQ5Z0h5dnRCenVmYU1rd0RlZ3RTVW8zS1lVYlM1RWpwSUpGWCtDTktmRzZ4?= =?utf-8?B?OWJua1J1SUphL1lhdk1OY2gvdjZ1U3hDeWhvM1R3cGpmbG9pV3hiS1lwWUR3?= =?utf-8?B?MGlWNmRJNW5odkZESHVMWEd0SkpxRWMzc1ZGdmZyR1ljWm5BektXTzcyLzdL?= =?utf-8?B?aXJTM25uM0pObUVucm8wQ1lpYmtYeUxveENuL2k0dHNGdHRTWU54Y0dDZ2Vn?= =?utf-8?B?TXc9PQ==?= Content-ID: <8D7A4DB5EAC3D746803F51DD4D621D4A@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5507.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef7792fc-1b63-4fc9-715c-08daf45fb147 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 05:41:45.8872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QSnqhyZow6/JvxWuHkQmDurL7XeePDrfAoxu9ldZQppmIZguEjhq1242M5eWDGS5V9hqYzRPaNkmSP4AO9mPMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5866 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 4/8] lavfi/vf_vpp_qsv: add vpp_preinit callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Do, 2023-01-12 at 05:49 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > On Do, 2023-01-12 at 05:11 +0100, Andreas Rheinhardt wrote: > > > Xiang, Haihao: > > > > From: Haihao Xiang > > > > > > > > Set the expected default value for options in this callback, hence we > > > > have the right values even if these options are not included in the > > > > option arrray. > > > > > > > > This is in preparation for reusing the code for other QSV filters. > > > > > > > > Signed-off-by: Haihao Xiang > > > > --- > > > > libavfilter/vf_vpp_qsv.c | 14 ++++++++++++++ > > > > 1 file changed, 14 insertions(+) > > > > > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > > > > index cf11cd7fdc..2a7b06fa33 100644 > > > > --- a/libavfilter/vf_vpp_qsv.c > > > > +++ b/libavfilter/vf_vpp_qsv.c > > > > @@ -259,6 +259,19 @@ release: > > > > return ret; > > > > } > > > > > > > > +static av_cold int vpp_preinit(AVFilterContext *ctx) > > > > +{ > > > > + VPPContext *vpp = ctx->priv; > > > > + /* For AV_OPT_TYPE_STRING options, NULL is handled in other way so > > > > + * we needn't set default value here > > > > + */ > > > > + vpp->saturation= 1.0; > > > > + vpp->contrast = 1.0; > > > > + vpp->transpose = -1; > > > > + > > > > + return 0; > > > > +} > > > > + > > > > static av_cold int vpp_init(AVFilterContext *ctx) > > > > { > > > > VPPContext *vpp = ctx->priv; > > > > @@ -683,6 +696,7 @@ const AVFilter ff_vf_vpp_qsv = { > > > > .name = "vpp_qsv", > > > > .description = NULL_IF_CONFIG_SMALL("Quick Sync Video VPP."), > > > > .priv_size = sizeof(VPPContext), > > > > + .preinit = vpp_preinit, > > > > .init = vpp_init, > > > > .uninit = vpp_uninit, > > > > FILTER_INPUTS(vpp_inputs), > > > > > > I do not get the point of this at all: None of these options are of type > > > AV_OPT_TYPE_STRING. You are merely setting the default values that > > > av_opt_set_defaults() would set lateron anyway. > > > I also fail to see how this would facilitate reusing this code for other > > > QSV filters. > > > > Actually this is a part of an old patchset, see > > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=4467, I want to use > > use > > functions and data structures defined in vf_vpp_qsv.c and qsvvpp.c to > > implement > > scale_qsv and deinterlace_qsv filters, hence we may remove vf_scale_qsv.c > > and > > vf_deinterlace_qsv.c > > > > E.g. > > saturation option is used in vpp_qsv filter but not in other qsv filters, so > > av_opt_set_defaults() works for saturation in vpp_qsv filter but not for > > other > > filters, we need to set a default value to vpp->saturation for other > > filters, > > otherwise vpp->saturation is 0 for other other filters. > > > > If you need this for other filters, then why do you add and use a > preinit callback for the filter that doesn't need it? I want to make sure these filters (include vpp_qsv filter) have the same default values for options at preinit stage. Thanks Haihao > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".