From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] tests/ref/fate/filter-metadata-cropdetect[12]: Fix ref file
Date: Sat, 30 Jul 2022 18:00:10 -0300
Message-ID: <d5d13cfd-ea0b-7481-2532-8db45f7a72c4@gmail.com> (raw)
In-Reply-To: <DB6PR0101MB22149714077ABB2032D36C198F989@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
On 7/30/2022 5:25 PM, Andreas Rheinhardt wrote:
> Necessitated by 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b
> and 425b309fa43236f4b7c098c7829b70a421fc1dd7.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> Did someone ever look why 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b
> made these changes?
My guess (because i only gave the code a cursory look) is that, since
we're now passing the frame as generated by lavfi through untouched,
what might have been empty frame metadata tags that
av_packet_pack_dictionary() was skipping when copying them to the packet
are now reflected (Or maybe av_packet_unpack_dictionary() is what was
skipping them from the raw data buffer when decoding the packet).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-30 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 20:23 [FFmpeg-devel] [PATCH 1/2] avfilter/vf_cropdetect: Remove set-but-unused variable Andreas Rheinhardt
2022-07-30 20:25 ` [FFmpeg-devel] [PATCH 2/2] tests/ref/fate/filter-metadata-cropdetect[12]: Fix ref file Andreas Rheinhardt
2022-07-30 21:00 ` James Almer [this message]
2022-07-30 20:26 ` [FFmpeg-devel] [PATCH 1/2] avfilter/vf_cropdetect: Remove set-but-unused variable Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d13cfd-ea0b-7481-2532-8db45f7a72c4@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git