From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50EBA40788 for ; Thu, 31 Mar 2022 11:51:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FE8D68B1E2; Thu, 31 Mar 2022 14:51:21 +0300 (EEST) Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3ECF768B148 for ; Thu, 31 Mar 2022 14:51:15 +0300 (EEST) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-df02f7e2c9so12621820fac.10 for ; Thu, 31 Mar 2022 04:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=mb1M+6VVWCsf8mDTwPto6VrHb3DyxiMtTWfAKnDlLNw=; b=dcRuVGdFruNlHjL32kFm7srtVVHyxvRGG5A92WD5uGZ5Sz8KZIdVdVKa/jw8P1eBh5 Pjw6KtQ6bGkLXXZdo4Ohsl4gL+Go3NZTRpRMEln5fsAliTirxM+Xbv9jxIRTUhYDtg4B n+SXp2RmoqWGl5X6ORqD2jV+ot7GqnMwMgYdPaZI1AVYZe+7k0+OasQ7v69TsXSnv+rE io4UrPUg5j/laxD8wT5NGlx+WLRm1AU6PgP5UdGhIOzUG1fZ1lsfpV9qnLN5Ybm8fI0f xJ3aq7wZiGNnJFDbe1inxkwx5jqymye8jQL63g0h27/j0pGwmyaO6MFPvEnuhyMkQ0dk DuJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=mb1M+6VVWCsf8mDTwPto6VrHb3DyxiMtTWfAKnDlLNw=; b=Ivo45f9klJ1mxjz5bM4dcyYJOZ8DbMRV2xdoUDEPsDKPbY7H9qYWarcEpE5s2vtEu7 KdIz8+nL25AkhqM0fxmVynbBDoafJfeBznpvr0dIy+pWn9vv87bDFa8jCnYJXxLWhSVT qdin2vD+o2YTHELxhtJsuykHfK6p+A9rWyl9dcdymzgrRqgv+Fq2dzeYEN/EPCfIRuSB lvPZVhUROhhePwujEmHRK85UAOk2LolaPIiJHs7XKB+dTxBaXRUyEn3GRhbkz05K+NXG 8/ruehF753btmhD9FX06rhN6anWyIolFWTSeTYUTlFFArXnZY23GiwUAF7Hpsv9X5H9v LKcw== X-Gm-Message-State: AOAM5301Qws3o2giv7/GB5DyFaNLbg6XqznGvuXmNg/u0UsS4SAjHc8G gGP5qnHodziDR4XAA4NKNr0/+zrnVHvByQ== X-Google-Smtp-Source: ABdhPJwCuePzug9PSTyb1qTjmn/nbyRmY6wZkUKTA6G16VHEzXvH0ZEaZ3oiV15DBkYIcmok+m/iMg== X-Received: by 2002:a05:6870:b62a:b0:de:bb:e5d6 with SMTP id cm42-20020a056870b62a00b000de00bbe5d6mr2382671oab.219.1648727472548; Thu, 31 Mar 2022 04:51:12 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id 67-20020aca0546000000b002d46e151b9bsm11880800oif.18.2022.03.31.04.51.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 04:51:11 -0700 (PDT) Message-ID: Date: Thu, 31 Mar 2022 08:51:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220223150355.944-1-jamrial@gmail.com> <20220223150355.944-2-jamrial@gmail.com> <164872722085.19727.6259130117482272789@lain.red.khirnov.net> From: James Almer In-Reply-To: <164872722085.19727.6259130117482272789@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/4 v2] ffmpeg: ensure a keyframe was not seen before skipping packets X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/31/2022 8:47 AM, Anton Khirnov wrote: > Quoting James Almer (2022-02-23 16:03:53) >> A keyframe could be buffered in the bsf and not be output until more packets >> had been fed to it. >> >> Signed-off-by: James Almer >> --- >> Changed the check from pkt to !eof, since a packet is always provided. >> >> fftools/ffmpeg.c | 4 +++- >> fftools/ffmpeg.h | 1 + >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c >> index 44043ef203..2b61c0d5aa 100644 >> --- a/fftools/ffmpeg.c >> +++ b/fftools/ffmpeg.c >> @@ -890,6 +890,8 @@ static void output_packet(OutputFile *of, AVPacket *pkt, >> >> /* apply the output bitstream filters */ >> if (ost->bsf_ctx) { >> + if (!eof && pkt->flags & AV_PKT_FLAG_KEY) >> + ost->seen_kf = 1; > > Shouldn't this also be set when no bsfs are used? Afaict only in streamcopy with bsfs scenarios can packets be temporarily withheld, so it's not necessary. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".