From: James Almer <jamrial-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: fix leak in sbg_read_header()
Date: Tue, 17 Jun 2025 11:28:58 -0300
Message-ID: <d594173a-e658-479f-88e6-f89f2c3f6d5b@gmail.com> (raw)
In-Reply-To: <aFF6ejV2MoAsTapE@phare.normalesup.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 498 bytes --]
On 6/17/2025 11:23 AM, Nicolas George wrote:
> Lidong Yan (HE12025-06-17):
>> In sbg_read_header(), if avformat_new_stream() failed, it returns
>> without cleanup, which may cause memory leaks. Replace return statement
>> with goto so that we would first clean up then return.
>>
>> Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
>> ---
>> libavformat/sbgdec.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> LGTM, thanks.
>
> Regards,
Pushed.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-17 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 14:14 [FFmpeg-devel] [PATCH 0/4] fix multiple memory leaks Lidong Yan
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 1/4] libavformat/rtmpproto: fix rmtp packet leak in gen_connect() Lidong Yan
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() Lidong Yan
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: fix leak in sbg_read_header() Lidong Yan
2025-06-17 14:23 ` Nicolas George
2025-06-17 14:28 ` James Almer [this message]
2025-06-17 14:14 ` [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header() Lidong Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d594173a-e658-479f-88e6-f89f2c3f6d5b@gmail.com \
--to=jamrial-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git