From: "Logan.Lyu" <Logan.Lyu@myais.com.cn>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "Michael Niedermayer" <michael@niedermayer.cc>,
"Martin Storsjö" <martin@martin.st>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] lavc/aarch64: new optimization for 8-bit hevc_pel_bi_pixels
Date: Fri, 24 Nov 2023 20:19:18 +0800
Message-ID: <d4bffca2-323b-4814-bc0f-4cf17f3940af@myais.com.cn> (raw)
In-Reply-To: <26bfb51a-ccb7-9144-0b8-f26879f5b5@martin.st>
Hi, Martin,
This is indeed a weird mistake... I don't know how to fixed it...
And can you try those .patch files I attached in every email? I
downloaded the attachment from the ffmpeg-devel mailing list I
subscribed to and applied it, and it seems to work.
If the method mentioned above still doesn't work, should I re-send the
.eml files one by one? Please tell me how to deal with it, I will be
grateful.
Thanks
在 2023/11/22 20:36, Martin Storsjö via ffmpeg-devel 写道:
> On Wed, 22 Nov 2023, Logan.Lyu wrote:
>
>> I can't reproduce the error you mentioned...
>>
>> I can apply patches to the ffmpeg master branch normally using 'git
>> apply xxx.patch/.eml' or 'git am xxx.patch/.eml'.
>
> I guess you have emails that haven't been through the complete
> delivery chain, while some later party might have rewritten things.
>
>> By the way, I create these patches by /'git format-patch -s -o "../"
>> --add-header "X-Unsent: 1" --suffix .eml --to ffmpeg-devel@ffmpeg.org
>> -6 --filename-max-length=100' /to generate .eml file. And /'git
>> format-patch -4 --filename-max-length=100' /to generate .patch file
>> as attachment to prevent encoding format problems in email files.
>> These command should be OK, right?
>
> That's right for generating the patch files. I guess the problem here
> isn't about the patch files themselves, but the email delivery of them.
>
>> Can you try these patches again? If the error still occurs, please
>> tell me how it occurred then I will fixed it.
>
> I also tried applying them now with "git am", and I got this:
>
> Applying: lavc/aarch64: new optimization for 8-bit hevc_pel_bi_pixels
> error: corrupt patch at line 194
> Patch failed at 0001 lavc/aarch64: new optimization for 8-bit
> hevc_pel_bi_pixels
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
>
> Thus, same issue here.
>
> In earlier iterations, the patches have arrived correctly when you
> have sent them as attachments, instead of when sending them as plain
> inline patches with git send-email.
>
> // Martin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-24 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 2:06 Logan.Lyu
2023-11-19 20:42 ` Michael Niedermayer
2023-11-22 12:30 ` Logan.Lyu
2023-11-22 12:36 ` Martin Storsjö via ffmpeg-devel
2023-11-24 12:19 ` Logan.Lyu [this message]
2023-11-24 12:30 ` Martin Storsjö
2023-12-01 19:29 ` Martin Storsjö
2023-12-01 18:09 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4bffca2-323b-4814-bc0f-4cf17f3940af@myais.com.cn \
--to=logan.lyu@myais.com.cn \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=martin@martin.st \
--cc=michael@niedermayer.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git