From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 9C43B4E295
	for <ffmpegdev@gitmailbox.com>; Sun,  8 Jun 2025 06:54:56 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7504668BF37;
	Sun,  8 Jun 2025 09:54:51 +0300 (EEST)
Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 023D068B78B
 for <ffmpeg-devel@ffmpeg.org>; Sun,  8 Jun 2025 09:54:43 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
 by iq.passwd.hu (Postfix) with ESMTP id B2D3EEC189
 for <ffmpeg-devel@ffmpeg.org>; Sun,  8 Jun 2025 08:51:42 +0200 (CEST)
X-Virus-Scanned: amavisd-new at passwd.hu
Received: from iq.passwd.hu ([127.0.0.1])
 by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id X6Iv4RbhYVhv for <ffmpeg-devel@ffmpeg.org>;
 Sun,  8 Jun 2025 08:51:41 +0200 (CEST)
Received: from iq (iq [217.27.212.140])
 by iq.passwd.hu (Postfix) with ESMTPS id 4A4A2EC174
 for <ffmpeg-devel@ffmpeg.org>; Sun,  8 Jun 2025 08:51:40 +0200 (CEST)
Date: Sun, 8 Jun 2025 08:51:40 +0200 (CEST)
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20250607232905.GK29660@pb2>
Message-ID: <d45f3aea-674c-7ea1-68b9-b172bb064dcb@passwd.hu>
References: <20250531133215.64025-1-michael@niedermayer.cc>
 <GV1P250MB07379E5A2ECA7030E299E9638F62A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <20250604010512.GN29660@pb2> <20250607232905.GK29660@pb2>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific
 macros
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/d45f3aea-674c-7ea1-68b9-b172bb064dcb@passwd.hu/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On Sun, 8 Jun 2025, Michael Niedermayer wrote:

> Hi
>
> On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote:
> [...]
>>>>  #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0)
>>>
>>> 1. I don't like that you change the common case (namely the integer one)
>>> and thereby making the name longer (and making this patch huge).
>>
>> I can just rename FFMINI/MAXI to FFMIN/MAX if preferred
>
> are there any objections to FFMIND / FFMINF / FFMAXD / FFMAXF ?
> if not i intend to apply these in the next days (unless i forget)

Some explanation still would be nice how you created the patch and made 
sure the proper macro is used in the proper place. What tool was used if 
any (Coccinelle? some LLM magic?).

Also it would be generally prefererred to split the patch to the addition 
of the new macros or function and the transition to it.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".