Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

[Marton Balint <cus@passwd.hu>]

On Sun, 8 Jun 2025, Michael Niedermayer wrote:

> Hi
>
> On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote:
> [...]
>>>>  #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0)
>>>
>>> 1. I don't like that you change the common case (namely the integer one)
>>> and thereby making the name longer (and making this patch huge).
>>
>> I can just rename FFMINI/MAXI to FFMIN/MAX if preferred
>
> are there any objections to FFMIND / FFMINF / FFMAXD / FFMAXF ?
> if not i intend to apply these in the next days (unless i forget)

Some explanation still would be nice how you created the patch and made 
sure the proper macro is used in the proper place. What tool was used if 
any (Coccinelle? some LLM magic?).

Also it would be generally prefererred to split the patch to the addition 
of the new macros or function and the transition to it.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".