From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 339154B09E for ; Mon, 27 May 2024 19:33:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1CAE68D4CF; Mon, 27 May 2024 22:33:34 +0300 (EEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACA7568D231 for ; Mon, 27 May 2024 22:33:27 +0300 (EEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f082d92864so967225ad.1 for ; Mon, 27 May 2024 12:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716838405; x=1717443205; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=tMsrfk/Eh4RcQHLrwAng9u5a5F+dz0asGZ6rL4WoIsQ=; b=EO9hMh7b16Y1TM1UvbhE+jT6BQ4NuXg9CrZ6MrADI3iAN/30lgaHVvlBX6B4rHKme3 NQQnLXOFe217pj5ad0DHGuKT4k6YYxI3/hC2C7QZJm9EsOstSAMO+i7cs3pJwoHrJtm4 Pgcbz3Zml5yJ77yKTplh2wpU/EZAXNfHGcwF0tpTPZFmCZnZ5PtEJvES6wS/yaZ8PPp6 P4c2xrrTzZgaj1CEwGZD8HjfZu77AyHx/wxdg8Q8tpr1Ut4U8LLAqHsNnW/P5Xg0gnH/ xIt2Z0QCjhHID0cAaNnj9irdwjqPJqZ6OLuBGcXuNzs2OW1WNpXJkgaYlLlQctvqWUtq Z2GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716838405; x=1717443205; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tMsrfk/Eh4RcQHLrwAng9u5a5F+dz0asGZ6rL4WoIsQ=; b=Fn0QuM9hmY24sSOyjACHb0DC5OfB/MPGKq0RNbGecp8obPZ9pyNr+6oky1HiIMQiJz 7eETXR2kUQvZWbJ4djk9uq0VOkf5iD6GHU/CmBfoyJr5a5TNEnbqz3gUEewwS/fgEGjg ukZwYtaP7pfU3K6wmBCL0Hvg3bwQcbjl1RxxJRYuXxPUpBfngZRu71fKKlnYVupZeI4c E3oQ7jYZKh1o9n3HxtzgPQNWCs2XalsUWpkysRgA0tHe2DHPc3RN1xKaSqE89C2G5Ogk xsdsmsgt+wH5DdDYZArnKp6/c9MKNDmQuhlAsq91lRAVmWpXMJZMAuQsWhthnRaitg0+ gbLA== X-Gm-Message-State: AOJu0Yxvdgj83ZJDJznb0v9VqddFNsrtrSpxxGrDujzD61sRci3Cn6pt hJfLThM733KX7lw8NRcUVzYLyZn7QgbGAjbX9k+nMwbGRy2Z2L7hKyc3Pg== X-Google-Smtp-Source: AGHT+IEl1H4dZX3DXDavDLb03KGvaOBUdF6/L2UEVU9kNF4mSCkKGpKWaBR4Py1pnCc86VxrzLTzNg== X-Received: by 2002:a17:902:db02:b0:1f4:8266:87d0 with SMTP id d9443c01a7336-1f482668ac2mr63414355ad.59.1716838404685; Mon, 27 May 2024 12:33:24 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c758128sm64688265ad.60.2024.05.27.12.33.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 12:33:24 -0700 (PDT) Message-ID: Date: Mon, 27 May 2024 16:33:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> <20240527181105.GN2821752@pb2> <703eafba-1d9a-458b-a4ee-f2092a73bd83@gmail.com> <20240527192055.GO2821752@pb2> <20240527193155.GP2821752@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240527193155.GP2821752@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/27/2024 4:31 PM, Michael Niedermayer wrote: > On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: >> On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: >>> On 5/27/2024 3:11 PM, Michael Niedermayer wrote: >>>> On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: >>>>> Quoting Michael Niedermayer (2024-04-27 02:36:23) >>>>>> This allows detecting issues in side data related code, same as what >>>>>> framecrc does for before already for packet data itself. >>>>>> >>>>>> Signed-off-by: Michael Niedermayer >>>>>> --- >>>>> >>>>> I am against this patch. Checksumming side data is a fundamentally wrong >>>>> thing to do. >>>> >>>> It, or something equivalent is neccessary for regression testing. >>>> (and it was you who asked also for the tests i run to be part of >>>> fate. But here you object to it) >>>> >>>> You know, not checking side data is not checking it so differences would then not be >>>> detected allowing for unintended changes to be introduced (aka bugs) >>> >>> You have seen how much code is needed to get hashing to work for all targets >>> with some types, >> >> framecrcenc.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- >> 1 file changed, 73 insertions(+), 3 deletions(-) >> >> 70 more lines of code, in my patch >> >> If we need another 70 to handle some corner cases, no idea if we do, thats >> still negligible >> >> >>> so it does feel like it's not the right thing to do. >> >> I dont think i can follow that logic >> >> >>> ffprobe (and f_sidedata) are what should be used for actual integrity >>> checks. >> >> ffprobe cannot test ffmpeg, ffmpeg is a seperate excutable >> >> If you suggest that side data should not be tested in FFmpeg while packet.data >> should be tested. That position seems inconsistant to me >> >> If you suggest that neither side data nor packet.data should be tested in FFmpeg >> iam confident that there would be a majority disagreeing. >> >> f_sidedata is not at the output of ffmpeg so even if it could test it, it >> does not test the ffmpeg output. >> We also dont replace running md5sum and framecrc on ffmpeg output by a bitstream >> filter. >> >> Again, there is need to test what comes out of FFmpeg, thats at the muxer level >> thats what framecrcenc does. > > There is also an additional aspect > and that is efficiency or "time taken by all fate tests" > framecrcenc already has all the side data, it costs basically 0 time to print that > > any ffprobe based check needs to run everything a 2nd time, so it will be slower > > also ffprobe is only good for side data from the demuxer. > my patch tests all cases including side data from the encoder or any other > source that gets forwarded to the muxer in each testcase. We could extend showinfo_bsf to print side data information. > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".