From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6971E40671 for ; Mon, 28 Feb 2022 06:39:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04BF368B1C5; Mon, 28 Feb 2022 08:39:36 +0200 (EET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E130768B000 for ; Mon, 28 Feb 2022 08:39:29 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646030375; x=1677566375; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0V591nqCK1tUOx4gVpjK6ZZCQjMsaNoDstgMQsgIoXw=; b=JlfcwsjjW0speI56iTOlkZt5XYyVg65JnpFXaffOIuZhyAyeseK0Nprd 2MUsJ1/T8NQk5+0gmg//yLEy0L6LNkWm3FcJq06G8HE7Vmt4z/35/ywo4 RV58T5z7wFAIUQZtR7XVAApayO6nL3ZxVUb2qYH+mmAxJuE0HTYk1dvZ5 gXPiSMBOwYZNC4yHXgNKFufcuROATFFw6t+4+Rq0qua3i86wsp0r7Ju2u qdNl/TrJTJp79GkD2ye6wAD9+25snYlH6Sw2+mICWtd9HzIbmlfqGebK9 x0g/Q0XtS6JrhTtMakXJM8LyeixnRiod33rCnKvPOj28ZQBD4yznQ+pXP w==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="240227301" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="240227301" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2022 22:39:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="534328583" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 27 Feb 2022 22:39:28 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 22:39:27 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 22:39:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 27 Feb 2022 22:39:27 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 27 Feb 2022 22:39:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hz1lToWWX9H0VP4KO2YQBnck9NLUvzu9xxBaTOH4OV5DoUtU+1p5aVrIWJfQsC0xoHC9q4KKWh5OiihikRrTnfjlfeeQpWYaeQAR2OTAOPzaiJRIerrJly7BYnnL1fZ6gD/VuOO271Zb60dRc5UjeEZczQfMNhba8AufJJhc5HPToAZuRxSD3IKTuWp5CoOeQ7OGN3mOQbunVzwK0+bwzHgCKtZOH8n+1tce1eCb7FDdX2R/Z8XftCOqZ39Dh8tbYxTxLzs27s+gpgS09efLNlwJUMhWnzE54lIZlY0iOxILUEblETlvIRl1oq/2ZIhjx409sJMx0KQy/bQI5Luj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0V591nqCK1tUOx4gVpjK6ZZCQjMsaNoDstgMQsgIoXw=; b=Nv7SqtwQejoA30tHElpkI0hkGofO2KYWAnnS8rSrqfDePLDMsMyihjNtD+3eBqBfyTqsmKQauASxsZndhfBGBcS7coN0JIABLZ8zkDDDwpVrc0ZKHFBVNpvQg7tb5VmIt/kD9njq9/Gl8QzVJkQcj6EtRzMnye9ksFnaUBUjVe8KJ0bDShJyhFSGjgPnUpqXRegx/fjVtAxcTKBJmkdCSTgiBoUPzsvZuOiUQhltrbO1zfugRGlJhMq6XgDdOvcpNZvIQrWbkVfOBkyc8uNBdPfKq0y6Iwx+lXjvbsCRQEKSTIabyEAggolVoeoNzHC+wUi1wzFoVkFUyOyJqJkJHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MWHPR11MB1311.namprd11.prod.outlook.com (2603:10b6:300:2a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Mon, 28 Feb 2022 06:39:26 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f%5]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022 06:39:26 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] qsv: add return value check for MFXQueryIMPL Thread-Index: AQHYKSYkGu1VflB4S0+dveXLSzk78KyoiYwA Date: Mon, 28 Feb 2022 06:39:25 +0000 Message-ID: References: <20220224022740.58216-1-tong1.wu@intel.com> In-Reply-To: <20220224022740.58216-1-tong1.wu@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e7119dd-f9fb-4d38-9f96-08d9fa851042 x-ms-traffictypediagnostic: MWHPR11MB1311:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UYK/O4m3/TIfQpIus/VjzwqKism3m7gz4JS6nYakdA2/UzxVrFpHOg0iG5jMnoiERFr4xdeyF3rpE3A1H1NGECMX+owyNgFFLpXfpo1cfqHswZBI8WNNZI4JxuVCiAI34TVlcMhCQzDeFPiflw/42/NjKTB8kOUVE2fgIUq7h5uCWTdXTqNG/KS1m6AVhecVj6XRYnsxCAQn4QNNQMsCSpRRtp348X6b3ybGcGfKNty/TqkpzVlUbqe9/hmKhKkqWERgn2UmRshpa5ZxJ0vcAf3vGVe36jJWR2c90CkBr8MZMzTRnhIIN0tVzf1TSWoGwfTjEeCNOOjXnf0NCzVAdeBx5dlkf6m0njwU+TrLkStRFjg8BRrPVkkJwd4mBQtWiNkbOwTHv95negrY7XWbdpZ6Qeuajoe/HgDwpV7RVgu6/JkJH4mls3wsn43IJ26AYOYy6puBnXJIX5bWGI6jiQ4OZv4W/qGMb3cnRtubUbfOlLSj6JO4BO3wmCbj5+3AN+UXbaCpkdkg+rtj2GSIwSmv2+OUSQ53/kMfrFn2Fz4yBtOwYeRgr0S2JKzc0LzlGy52ijZT75ED5izN0lmuA7yobTKNqWcAKZC/BlqgB9pOJ+ePxw0dy61r8CZx79cX2p40VcSkQRLe8p35aibvidg6vLAuDO0Foy2TAkV8sZSLDXiuF3ioPSCsGfa04QcRiI3Hlifv/T4XjUA7LPzL98FclLS+Y2cEBZ1i0ZHMFQ0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(91956017)(36756003)(83380400001)(66946007)(66556008)(66476007)(64756008)(8676002)(86362001)(66446008)(5660300002)(4326008)(508600001)(2616005)(6486002)(71200400001)(4744005)(38100700002)(8936002)(2906002)(107886003)(26005)(38070700005)(82960400001)(186003)(6506007)(122000001)(6916009)(316002)(6512007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V2doY3U4UjVHRnc2U2luNmtmbDZUZ2FUOVY3VmwzMS9GNFZXSk9zaEpnbTNU?= =?utf-8?B?RHQ2RGVMVE1xSmVLd09UZHNJenc0emJ6a2VCaXhaVUd2TFR0MlppZ29qVEZU?= =?utf-8?B?aEJTMFhtcHIrSzFJUVgwZ3ROSUJESWxPQ29MMnR4d1FkMEJiYzZhK20zY3JZ?= =?utf-8?B?bklHYjBtRHZNM1d1YXc1T2hGS1ZCNm5EcWw0NmJsYVRueTgyTkw3VnNIckRG?= =?utf-8?B?Sm1YWndDZlF1RktLVnZqeXk5SllMUUYvTjlFOFRhdGticTBDYXk3UURkekZk?= =?utf-8?B?dVVYb09PRXJ5bDRNM05qdEl5WnNRRUtBOVU2NjF0VENlSHpPSEpVTkNMMURs?= =?utf-8?B?VGJTeXFFV2ZWNWpYbmg4dW9uQXgvZnYyYndqbGtpL1ZHM3FVUUU3NDhscE10?= =?utf-8?B?M2ZFMzlMRGpVWlNFdWJERHlCM3l4QVZZQ2lQZzBYL09ZbnlpY3NlQTl1ZUhs?= =?utf-8?B?blp2dzdzdU5KUUdoM0ZjTFIxY0gxaXlocGhMT3dLL0ZVYXR5bklldzNnRFkr?= =?utf-8?B?cTBrdDFNR2hEamx3dXc1TEYxUEVLODBJK1FITlEybHM5dlV4LzhaODlEQldz?= =?utf-8?B?VldodXpIUDF5MFFtWk5xbHlDaU9mOTVUNENnNXpQSDNIaGhmSm9sc21QVHV5?= =?utf-8?B?clkyU09CZEQ5WmFSNEltZlJrNlE4dERnS1E3eSsrOEJsMXpkR2hndzlnenNG?= =?utf-8?B?NHNBRnhiMlpKbnJxZDVKNEZzY2JVTFdCUlV2Rk5IRFVwWXhxQUZTQW55STBZ?= =?utf-8?B?RCs1QzU0ZmkvY08yYnhXdktYd2RtU3BwMnZaWUh4MmdEVW5kUzNjYkRMbm5B?= =?utf-8?B?Z3dPRWZuTFhzZDhVVUM0SGxPdWNnRjBSOC9ncFFLRmphdHloZ29vYitBV0Np?= =?utf-8?B?MzJ6Wm9LNUdlREpySmp3YXZQKzFmYUEzL3BZM29odHprSGNuN1JDZWNjOGR4?= =?utf-8?B?QnNiZkJ0cUhTZDVNUEZzZUp3SFA3MDZIWGlRWUJBZE5idTNZbFBCaVkrU0tJ?= =?utf-8?B?Z2xoellkUERCaHpldU1kLzI1RWc3aDBVdEZ6cHlSaFg5TUpkeCt1ZXFDcjg3?= =?utf-8?B?WFN3bDdGeFVSZloySHZwWVR4clo5ZC8vbWFOWXJJZHl2MXJiYkdlcnk4OEJ5?= =?utf-8?B?QnFEU2hpdEVBdDJZaHlNZWZxSitCVlNWcU5UMjRhMEpEV09ycDlGZ2dQcXdB?= =?utf-8?B?UXlnak11SGpJSkg0a2hYaitNak10STVkL3c5WFQzbjArK3M5UVR2Ym9GN3lm?= =?utf-8?B?d1lRZm9ZQlYyc1ByYW9zcEh6QlBwOUJWbktHOE9MZ1RyOVRnczV5MldJYno4?= =?utf-8?B?ekQ1L3Npc1JxaDNTMGJpZlJIOEdSdC9vYnoxK2Yrdmx2YU5sUjZ2bkxoRXdS?= =?utf-8?B?cm43Rmh2N2xab1JUbG5ybDBldVJnc2UyU3M0R1JvbWlLNDRxMlRObjBFN0Mw?= =?utf-8?B?UFZWRU5ucm1TVzZNaW4wTjc0VFkrczRleWxUbWJUcWdMekZXTndPY1BLMHQr?= =?utf-8?B?UmI2NC9BeFRkcy9pUzA5K2hvbW96eW9VTzFnLzlQaHVDMzBMenoyL0l1QVc0?= =?utf-8?B?SG1FWms5aDg5bGZuQWFFREZRTmtQaEpjNUZ3NTB5c2ZXSnMzdkV2Y2d5ZXZ3?= =?utf-8?B?SG1ORXkvV05idS92bEtSSTA1RWxaWDRSak5TakpFcDdiOHMwVTFFNHNWWW9u?= =?utf-8?B?WThTbUxOVTA0RnJuTmlXVXpIZUF2YVcvMmw1eC9NQUpZVU5FRy9hU1ZKRS9D?= =?utf-8?B?WFE2M045UmVsSDZDcHJucCtZaDVnQUNrZzRNaytiRmpOTVhCOEEzeUxWQlpH?= =?utf-8?B?aGk2OGxiZGs5UkxvdldrQjFyemZQQWVEV2ZSRE9BeVB4c3BOdHpDempiU2tB?= =?utf-8?B?Vm5CUzFnQkxYZnovZ2ZTNGtid3QwZkNveXFCcWFSMGNSR1FKQmxTTE1vd2Y0?= =?utf-8?B?bGpTd0pDd290Zmt6Q2VyUVlTQk1qQTVrNllUTkM1eXVLRnB3ZEt6OHhDVGY4?= =?utf-8?B?SDN1d1pPQ3hYc3BYRTBMQ2orSlc4Q2U0OC9VRTY0UFZmZCtFM1NWczJiZEFC?= =?utf-8?B?YVRQNjhrd1pBcVRiUTBsWitmVTROQjkwTHAyS1d2VjJ0OTdOMDlhOXB4RVBR?= =?utf-8?B?OE5SZkUzZWo0V3FKRitvTUhRZmgxb0R3QU9wbXBVWlErLzRyMXZvK0grZGx2?= =?utf-8?Q?XHE4YKfY6rHSxuFkkmedt8E=3D?= Content-ID: <204DE5192FBE924CA00FA8ACBD774281@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7119dd-f9fb-4d38-9f96-08d9fa851042 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 06:39:25.9094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YyBh4GhZag5hkb5d5HDG0SxvJP7UVuNLZLijAMeJcCQqjjElUd8QCZ+/xvYoxKuT140YJzVVCdOsbMsw8DDUdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1311 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] qsv: add return value check for MFXQueryIMPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wu, Tong1" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-02-24 at 10:27 +0800, Tong Wu wrote: > add a return value check for function MFXQueryIMPL to handle the error > message. > > Signed-off-by: Tong Wu > --- > libavcodec/qsv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index 1a432dbd82..18f34f05fd 100644 > --- a/libavcodec/qsv.c > +++ b/libavcodec/qsv.c > @@ -408,7 +408,10 @@ int ff_qsv_init_internal_session(AVCodecContext *avctx, > QSVSession *qs, > return ret; > } > > - MFXQueryIMPL(qs->session, &impl); > + ret = MFXQueryIMPL(qs->session, &impl); > + if (ret != MFX_ERR_NONE) > + return ff_qsv_print_error(avctx, ret, > + "Error querying the session attributes"); > > switch (MFX_IMPL_BASETYPE(impl)) { > case MFX_IMPL_SOFTWARE: LGTM, applied -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".