Re: [FFmpeg-devel] [PATCH] qsv: add return value check for MFXQueryIMPL

From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Wu, Tong1" <tong1.wu@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH] qsv: add return value check for MFXQueryIMPL
Date: Mon, 28 Feb 2022 06:39:25 +0000
Message-ID: <d4200724c5d74ca4b8fe112a8645c6c0a9bb5c0a.camel@intel.com> (raw)
In-Reply-To: <20220224022740.58216-1-tong1.wu@intel.com>

On Thu, 2022-02-24 at 10:27 +0800, Tong Wu wrote:
> add a return value check for function MFXQueryIMPL to handle the error
> message.
> 
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
>  libavcodec/qsv.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
> index 1a432dbd82..18f34f05fd 100644
> --- a/libavcodec/qsv.c
> +++ b/libavcodec/qsv.c
> @@ -408,7 +408,10 @@ int ff_qsv_init_internal_session(AVCodecContext *avctx,
> QSVSession *qs,
>          return ret;
>      }
>  
> -    MFXQueryIMPL(qs->session, &impl);
> +    ret = MFXQueryIMPL(qs->session, &impl);
> +    if (ret != MFX_ERR_NONE)
> +        return ff_qsv_print_error(avctx, ret,
> +                                  "Error querying the session attributes");
>  
>      switch (MFX_IMPL_BASETYPE(impl)) {
>      case MFX_IMPL_SOFTWARE:

LGTM, applied

-Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".