Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/4] avformat/iamfenc: don't write empty packets
@ 2024-01-07 21:30 James Almer
  2024-01-07 21:30 ` [FFmpeg-devel] [PATCH 2/4] fftools/cmdutils: add OPT_TYPE_FILE James Almer
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: James Almer @ 2024-01-07 21:30 UTC (permalink / raw)
  To: ffmpeg-devel

And return an error if they are not side data only packets.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/iamfenc.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c
index 1de416b663..a02f84035a 100644
--- a/libavformat/iamfenc.c
+++ b/libavformat/iamfenc.c
@@ -278,6 +278,16 @@ static int iamf_write_packet(AVFormatContext *s, AVPacket *pkt)
     int dyn_size, type = st->id <= 17 ? st->id + IAMF_OBU_IA_AUDIO_FRAME_ID0 : IAMF_OBU_IA_AUDIO_FRAME;
     int ret;
 
+    if (!pkt->size) {
+        uint8_t *new_extradata = av_packet_get_side_data(pkt, AV_PKT_DATA_NEW_EXTRADATA, NULL);
+
+        if (!new_extradata)
+            return AVERROR_INVALIDDATA;
+
+        // TODO: update FLAC Streaminfo on seekable output
+        return 0;
+    }
+
     if (s->nb_stream_groups && st->id == c->first_stream_id) {
         AVIAMFParamDefinition *mix =
             (AVIAMFParamDefinition *)av_packet_get_side_data(pkt, AV_PKT_DATA_IAMF_MIX_GAIN_PARAM, NULL);
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-01-11 12:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-07 21:30 [FFmpeg-devel] [PATCH 1/4] avformat/iamfenc: don't write empty packets James Almer
2024-01-07 21:30 ` [FFmpeg-devel] [PATCH 2/4] fftools/cmdutils: add OPT_TYPE_FILE James Almer
2024-01-07 21:30 ` [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option James Almer
2024-01-08  1:43   ` Steven Liu
2024-01-08  1:44     ` James Almer
2024-01-07 21:31 ` [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests James Almer
2024-01-10  3:05   ` Michael Niedermayer
2024-01-10 12:52     ` James Almer
2024-01-11  3:17       ` Michael Niedermayer
2024-01-11 12:02         ` James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git